Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2562193002: Add filtering by priority in the Network filter area. (Closed)
Patch Set: Doctype Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
index 3a5a3d898c60dcf9268f83f2e417d6f3933af91f..bff7d1641d83bc72a1b777679da7abdea7a808dd 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
@@ -214,6 +214,15 @@ Network.NetworkLogView = class extends UI.VBox {
* @param {!SDK.NetworkRequest} request
* @return {boolean}
*/
+ static _requestPriorityFilter(value, request) {
+ return request.initialPriority() === value;
+ }
+
+ /**
+ * @param {string} value
+ * @param {!SDK.NetworkRequest} request
+ * @return {boolean}
+ */
static _requestMimeTypeFilter(value, request) {
return request.mimeType === value;
}
@@ -937,6 +946,12 @@ Network.NetworkLogView = class extends UI.VBox {
this._suggestionBuilder.addItem(Network.NetworkLogView.FilterType.Scheme, '' + request.scheme);
this._suggestionBuilder.addItem(Network.NetworkLogView.FilterType.StatusCode, '' + request.statusCode);
+ var priority = request.initialPriority();
+ if (priority) {
+ this._suggestionBuilder.addItem(
+ Network.NetworkLogView.FilterType.Priority, Components.uiLabelForPriority(priority));
+ }
+
if (request.mixedContentType !== 'none') {
this._suggestionBuilder.addItem(
Network.NetworkLogView.FilterType.MixedContent, Network.NetworkLogView.MixedContentFilterValues.All);
@@ -1446,6 +1461,9 @@ Network.NetworkLogView = class extends UI.VBox {
case Network.NetworkLogView.FilterType.SetCookieValue:
return Network.NetworkLogView._requestSetCookieValueFilter.bind(null, value);
+ case Network.NetworkLogView.FilterType.Priority:
+ return Network.NetworkLogView._requestPriorityFilter.bind(null, Components.uiLabelToPriority(value));
+
case Network.NetworkLogView.FilterType.StatusCode:
return Network.NetworkLogView._statusCodeFilter.bind(null, value);
}
@@ -1679,6 +1697,7 @@ Network.NetworkLogView.FilterType = {
Method: 'method',
MimeType: 'mime-type',
MixedContent: 'mixed-content',
+ Priority: 'priority',
Scheme: 'scheme',
SetCookieDomain: 'set-cookie-domain',
SetCookieName: 'set-cookie-name',
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698