Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1454)

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js

Issue 2562193002: Add filtering by priority in the Network filter area. (Closed)
Patch Set: Doctype Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « AUTHORS ('k') | third_party/WebKit/Source/devtools/front_end/network/FilterSuggestionBuilder.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js
diff --git a/third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js b/third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js
index a6ee2c2bf6e7942db2477b92e4d5c9b107130bd8..393c6a5b1a566eb5f1d2066711314ab21736e0c8 100644
--- a/third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js
+++ b/third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js
@@ -484,20 +484,69 @@ Components.NetworkConditionsActionDelegate = class {
};
/**
- * @param {?Protocol.Network.ResourcePriority} priority
+ * @param {!Protocol.Network.ResourcePriority} priority
* @return {string}
*/
Components.uiLabelForPriority = function(priority) {
- var labelMap = Components.uiLabelForPriority._priorityToUILabel;
- if (!labelMap) {
- labelMap = new Map([
- [Protocol.Network.ResourcePriority.VeryLow, Common.UIString('Lowest')],
- [Protocol.Network.ResourcePriority.Low, Common.UIString('Low')],
- [Protocol.Network.ResourcePriority.Medium, Common.UIString('Medium')],
- [Protocol.Network.ResourcePriority.High, Common.UIString('High')],
- [Protocol.Network.ResourcePriority.VeryHigh, Common.UIString('Highest')]
- ]);
- Components.uiLabelForPriority._priorityToUILabel = labelMap;
- }
- return labelMap.get(priority) || Common.UIString('Unknown');
+ var map = Components.priorityUiLabelMap();
+ return map.get(priority) || '';
+};
+
+/**
+ * @param {string} priorityLabel
+ * @return {string}
+ */
+Components.uiLabelToPriority = function(priorityLabel) {
+ /** @type {!Map<string, !Protocol.Network.ResourcePriority>} */
+ var labelToPriorityMap = Components.uiLabelToPriority._uiLabelToPriorityMap;
+
+ if (labelToPriorityMap)
+ return labelToPriorityMap.get(priorityLabel);
+
+ labelToPriorityMap = new Map();
+ Components.priorityUiLabelMap().forEach((value, key) => labelToPriorityMap.set(value, key));
+ Components.uiLabelToPriority._uiLabelToPriorityMap = labelToPriorityMap;
+ return labelToPriorityMap.get(priorityLabel) || '';
+};
+
+/**
+ * @return {!Map<!Protocol.Network.ResourcePriority, string>}
+ */
+Components.priorityUiLabelMap = function() {
+ /** @type {!Map<!Protocol.Network.ResourcePriority, string>} */
+ var map = Components.priorityUiLabelMap._priorityUiLabelMap;
+
+ if (map)
+ return map;
+
+ map = new Map();
+ map.set(Protocol.Network.ResourcePriority.VeryLow, Common.UIString('Lowest'));
+ map.set(Protocol.Network.ResourcePriority.Low, Common.UIString('Low'));
+ map.set(Protocol.Network.ResourcePriority.Medium, Common.UIString('Medium'));
+ map.set(Protocol.Network.ResourcePriority.High, Common.UIString('High'));
+ map.set(Protocol.Network.ResourcePriority.VeryHigh, Common.UIString('Highest'));
+ Components.priorityUiLabelMap._priorityUiLabelMap = map;
+
+ return map;
+};
+
+/**
+ * @return {!Map<!Protocol.Network.ResourcePriority, number>}
+ */
+Components.prioritySymbolToNumericMap = function() {
+ /** @type {!Map<!Protocol.Network.ResourcePriority, number>} */
+ var priorityMap = Components.prioritySymbolToNumericMap._symbolicToNumericPriorityMap;
+
+ if (priorityMap)
+ return priorityMap;
+
+ priorityMap = new Map();
+ priorityMap.set(Protocol.Network.ResourcePriority.VeryLow, 1);
+ priorityMap.set(Protocol.Network.ResourcePriority.Low, 2);
+ priorityMap.set(Protocol.Network.ResourcePriority.Medium, 3);
+ priorityMap.set(Protocol.Network.ResourcePriority.High, 4);
+ priorityMap.set(Protocol.Network.ResourcePriority.VeryHigh, 5);
+ Components.prioritySymbolToNumericMap._symbolicToNumericPriorityMap = priorityMap;
+
+ return priorityMap;
};
« no previous file with comments | « AUTHORS ('k') | third_party/WebKit/Source/devtools/front_end/network/FilterSuggestionBuilder.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698