Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2015 The Chromium Authors. All rights reserved. | 1 // Copyright 2015 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 /** | 4 /** |
| 5 * @unrestricted | 5 * @unrestricted |
| 6 */ | 6 */ |
| 7 Components.NetworkConditionsSelector = class { | 7 Components.NetworkConditionsSelector = class { |
| 8 /** | 8 /** |
| 9 * @param {function(!Array<!Components.NetworkConditionsGroup>):!Array<?SDK.Ne tworkManager.Conditions>} populateCallback | 9 * @param {function(!Array<!Components.NetworkConditionsGroup>):!Array<?SDK.Ne tworkManager.Conditions>} populateCallback |
| 10 * @param {function(number)} selectCallback | 10 * @param {function(number)} selectCallback |
| (...skipping 470 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 481 } | 481 } |
| 482 return false; | 482 return false; |
| 483 } | 483 } |
| 484 }; | 484 }; |
| 485 | 485 |
| 486 /** | 486 /** |
| 487 * @param {?Protocol.Network.ResourcePriority} priority | 487 * @param {?Protocol.Network.ResourcePriority} priority |
| 488 * @return {string} | 488 * @return {string} |
| 489 */ | 489 */ |
| 490 Components.uiLabelForPriority = function(priority) { | 490 Components.uiLabelForPriority = function(priority) { |
| 491 var labelMap = Components.uiLabelForPriority._priorityToUILabel; | 491 var map = Components.priorityUiLabelMap(); |
| 492 if (!labelMap) { | 492 return map.get(priority) || Common.UIString('Unknown'); |
|
allada
2016/12/20 01:35:00
Lets just return empty string if no match (no need
| |
| 493 labelMap = new Map([ | 493 }; |
| 494 [Protocol.Network.ResourcePriority.VeryLow, Common.UIString('Lowest')], | 494 |
| 495 [Protocol.Network.ResourcePriority.Low, Common.UIString('Low')], | 495 /** |
| 496 [Protocol.Network.ResourcePriority.Medium, Common.UIString('Medium')], | 496 * @param {string} priorityLabel |
| 497 [Protocol.Network.ResourcePriority.High, Common.UIString('High')], | 497 * @return {string} |
| 498 [Protocol.Network.ResourcePriority.VeryHigh, Common.UIString('Highest')] | 498 */ |
| 499 ]); | 499 Components.uiLabelToPriority = function(priorityLabel) { |
| 500 Components.uiLabelForPriority._priorityToUILabel = labelMap; | 500 var labelToPriorityMap = Components.uiLabelToPriority._uiLabelToPriorityMap; |
| 501 | |
| 502 if (labelToPriorityMap) | |
| 503 return labelToPriorityMap.get(priorityLabel); | |
| 504 | |
| 505 labelToPriorityMap = Components.priorityUiLabelMap().inverse({regularMap: true }); | |
|
allada
2016/12/20 01:35:00
Lets use:
labelToPriorityMap = new Map();
Compone
| |
| 506 Components.uiLabelToPriority._uiLabelToPriorityMap = labelToPriorityMap; | |
| 507 return labelToPriorityMap.get(priorityLabel) || ''; | |
| 508 }; | |
| 509 | |
| 510 /** | |
| 511 * @return {!Map} | |
|
allada
2016/12/20 01:35:00
nit: Incomplete definition
@return {!Map<!Protoco
| |
| 512 */ | |
| 513 Components.priorityUiLabelMap = function() { | |
| 514 var map = Components.priorityUiLabelMap._priorityUiLabelMap; | |
| 515 | |
| 516 if (map) | |
| 517 return map; | |
| 518 | |
| 519 map = new Map([ | |
|
allada
2016/12/20 01:35:00
nit: I am trying to doctype as much as possible, s
allada
2016/12/20 01:35:00
nit: This code should look similar to the code bel
| |
| 520 [Protocol.Network.ResourcePriority.VeryLow, Common.UIString('Lowest')], | |
| 521 [Protocol.Network.ResourcePriority.Low, Common.UIString('Low')], | |
| 522 [Protocol.Network.ResourcePriority.Medium, Common.UIString('Medium')], | |
| 523 [Protocol.Network.ResourcePriority.High, Common.UIString('High')], | |
| 524 [Protocol.Network.ResourcePriority.VeryHigh, Common.UIString('Highest')] | |
| 525 ]); | |
| 526 Components.priorityUiLabelMap._priorityUiLabelMap = map; | |
| 527 | |
| 528 return map; | |
| 529 }; | |
| 530 | |
| 531 /** | |
| 532 * @return {!Map} | |
|
allada
2016/12/20 01:35:00
nit: Incomplete definition
@return {!Map<!Protoco
| |
| 533 */ | |
| 534 Components.symbolicToNumericMap = function() { | |
|
allada
2016/12/20 01:35:00
Sorry, lets rename this: "prioritySymbolToNumericM
| |
| 535 var priorityMap = Components.symbolicToNumericMap._symbolicToNumericPriorityMa p; | |
| 536 | |
| 537 if (!priorityMap) { | |
|
allada
2016/12/20 01:35:00
nit: We use early returns when possible to reduce
| |
| 538 Components.symbolicToNumericMap._symbolicToNumericPriorityMap = new Map(); | |
|
allada
2016/12/20 01:35:00
nit: I am trying to doctype as much as possible, s
| |
| 539 priorityMap = Components.symbolicToNumericMap._symbolicToNumericPriorityMap; | |
| 540 priorityMap.set(Protocol.Network.ResourcePriority.VeryLow, 1); | |
| 541 priorityMap.set(Protocol.Network.ResourcePriority.Low, 2); | |
| 542 priorityMap.set(Protocol.Network.ResourcePriority.Medium, 3); | |
| 543 priorityMap.set(Protocol.Network.ResourcePriority.High, 4); | |
| 544 priorityMap.set(Protocol.Network.ResourcePriority.VeryHigh, 5); | |
| 501 } | 545 } |
| 502 return labelMap.get(priority) || Common.UIString('Unknown'); | 546 |
| 547 return priorityMap; | |
| 503 }; | 548 }; |
| OLD | NEW |