chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html - Issue 2562123002: MD Settings: Bluetooth: Update icon and title to reflect state

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html

Issue 2562123002: MD Settings: Bluetooth: Update icon and title to reflect state (Closed)

Patch Set: . Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html

diff --git a/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html b/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html

index 9bbffbca128eb7a9de9a327fd6a05d7c7579688c..2ef1a46b26c5fc977bf6c7e6ce4fcb32a5dc498b 100644

--- a/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html

+++ b/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html

@@ -42,8 +42,9 @@

<div class="settings-box first" actionable

on-tap="toggleDeviceListExpanded_">

- <iron-icon icon="settings:bluetooth"></iron-icon>

- <span class="middle flex">$i18n{bluetoothEnable}</span>

+ <iron-icon icon="[[getIcon_(bluetoothEnabled_, deviceConnected_)]]">

+ </iron-icon>

+ <span class="middle flex">[[getTitle_(bluetoothEnabled_)]]</span>

dschuyler 2016/12/13 00:54:43 IIUC, when the toggle changes, the text for the to

stevenjb 2016/12/13 19:22:36 See the associated bug, filed by our UX designer :

<cr-policy-pref-indicator

pref="[[prefs.cros.device.allow_bluetooth]]"

hidden="[[prefs.cros.device.allow_bluetooth.value]]">

« no previous file with comments | « chrome/app/settings_strings.grdp ('k') | chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js » ('j') | no next file with comments »