Move DocumentXMLTreeViewer off of private script

third_party/WebKit/Source/core/xml/DocumentXMLTreeViewer.cpp

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "core/xml/DocumentXMLTreeViewer.h"
+
+#include "bindings/core/v8/DOMWrapperWorld.h"
+#include "bindings/core/v8/ScriptController.h"
+#include "bindings/core/v8/ScriptSourceCode.h"
+#include "core/dom/Document.h"
+#include "core/dom/Element.h"
+#include "core/frame/LocalFrame.h"
+#include "platform/PlatformResourceLoader.h"
+#include "public/platform/Platform.h"

[jbroman, 2016/12/13 15:41:05]

last minute nit: this include is now unused

[adithyas, 2016/12/13 16:18:16]

Removed.

+
+namespace blink {
+
+void transformDocumentToXMLTreeView(Document* document) {
+  String scriptString = loadResourceAsASCIIString("DocumentXMLTreeViewer.js");
+  String cssString = loadResourceAsASCIIString("DocumentXMLTreeViewer.css");
+
+  HeapVector<ScriptSourceCode> sources;
+  sources.append(ScriptSourceCode(scriptString));
+  v8::HandleScope handleScope(v8::Isolate::GetCurrent());

[jbroman, 2016/12/13 15:41:05]

super-nit: V8PerIsolateData::mainThreadIsolate() is probably better (doesn't
need thread-local storage, and Isolate::GetCurrent is discouraged anyhow).

[adithyas, 2016/12/13 16:18:16]

Changed to use V8PerIsolateData::mainThreadIsolate() now

+
+  document->frame()->script().executeScriptInIsolatedWorld(
+      WorldIdConstants::DocumentXMLTreeViewerWorldId, sources, 0, nullptr);
+  document->getElementById("xml-viewer-style")->setTextContent(cssString);

[esprehn, 2016/12/12 22:21:57]

I'm pretty sure you can actually get into a situation with a window.open()'ed
script where a mutation event would then remove this style tag and this would
crash.

You want to do:

Element* element = document->getElementById("xml-viewer-style");
if (element)
  element->setTextContent(...);

[adithyas, 2016/12/13 16:18:17]

Fixed

+}
+
+}  // namespace blink