Move DocumentXMLTreeViewer off of private script

third_party/WebKit/Source/core/xml/DocumentXMLTreeViewer.cpp

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "core/xml/DocumentXMLTreeViewer.h"
+
+#include "bindings/core/v8/DOMWrapperWorld.h"
+#include "bindings/core/v8/ScriptController.h"
+#include "bindings/core/v8/ScriptSourceCode.h"
+#include "core/dom/Document.h"
+#include "core/dom/Element.h"
+#include "core/frame/LocalFrame.h"
+#include "public/platform/Platform.h"
+
+namespace blink {
+
+void DocumentXMLTreeViewer::transformDocumentToTreeView() {
+  WebData DocumentXMLTreeViewerJs =
+      blink::Platform::current()->loadResource("DocumentXMLTreeViewer.js");
+  WebData DocumentXMLTreeViewerCSS =
+      blink::Platform::current()->loadResource("DocumentXMLTreeViewer.css");
+
+  String scriptString(DocumentXMLTreeViewerJs.data(),

[jbroman, 2016/12/10 20:35:31]

Nit: this assumes with no check that the data will be Latin-1 encoded. We
usually use UTF-8, so that essentially means these must be ASCII. They are, but
you could use loadResourceAsASCIIString from PlatformResourceLoader.h, which
checks that and does the conversion.

[adithyas, 2016/12/12 16:13:50]

Done.

+                      DocumentXMLTreeViewerJs.size());
+  String cssString(DocumentXMLTreeViewerCSS.data(),
+                   DocumentXMLTreeViewerCSS.size());
+
+  HeapVector<ScriptSourceCode> sources;
+  sources.append(ScriptSourceCode(scriptString));
+  v8::HandleScope handleScope(v8::Isolate::GetCurrent());
+
+  m_document->frame()->script().executeScriptInIsolatedWorld(
+      WorldIdConstants::DocumentXMLTreeViewerWorldId, sources, 0, nullptr);

[haraken, 2016/12/12 01:09:56]

Does this need to be executed in an isolated world? I guess we can just use the
main world.

Would you check what world we had been using two years ago before we converted
XMLTreeViewer to Blink-in-JS?

[adithyas, 2016/12/12 16:13:50]

We used to use the main world to execute the script. jbroman@ recommended using
an isolated world to prevent other frames from being able to access the tree
viewer's objects, which I think makes sense. 

+  m_document->getElementById("xml-viewer-style")->setTextContent(cssString);
+}
+
+DEFINE_TRACE(DocumentXMLTreeViewer) {
+  visitor->trace(m_document);
+}
+
+}  // namespace blink