Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1259)

Unified Diff: pkg/analysis_server/test/analysis/notification_analysis_options_test.dart

Issue 2562083002: Get some tests running using the analysis driver (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/analysis/notification_analysis_options_test.dart
diff --git a/pkg/analysis_server/test/analysis/notification_analysis_options_test.dart b/pkg/analysis_server/test/analysis/notification_analysis_options_test.dart
index 89f720363632ede8c030b779db45d7e0f1decd3c..7384a54f5b338b10b05292b75730e64767b5bd25 100644
--- a/pkg/analysis_server/test/analysis/notification_analysis_options_test.dart
+++ b/pkg/analysis_server/test/analysis/notification_analysis_options_test.dart
@@ -4,11 +4,11 @@
library test.analysis.notification_analysis_options_test;
-import 'package:analysis_server/plugin/protocol/protocol.dart';
+import 'package:analysis_server/plugin/protocol/protocol.dart'
+ hide AnalysisOptions;
import 'package:analysis_server/src/constants.dart';
import 'package:analysis_server/src/domain_analysis.dart';
import 'package:analyzer/src/generated/engine.dart';
-import 'package:analyzer/src/services/lint.dart';
import 'package:linter/src/rules.dart';
import 'package:test/test.dart';
import 'package:test_reflective_loader/test_reflective_loader.dart';
@@ -20,6 +20,11 @@ main() {
defineReflectiveSuite(() {
defineReflectiveTests(NewAnalysisOptionsFileNotificationTest);
defineReflectiveTests(OldAnalysisOptionsFileNotificationTest);
+ // These tests all fail, presumably because we are not updating the analysis
+ // options when the file changes and because we are not analyzing the
+ // analysis options file.
+// defineReflectiveTests(NewAnalysisOptionsFileNotificationTest_Driver);
+// defineReflectiveTests(OldAnalysisOptionsFileNotificationTest_Driver);
});
}
@@ -40,8 +45,6 @@ main() {
String get optionsFilePath;
- AnalysisContext get testContext => server.getContainingContext(testFile);
-
List<AnalysisError> get testFileErrors => filesErrors[testFile];
void addOptionsFile(String contents) {
@@ -105,9 +108,11 @@ main() {
await waitForTasksFinished();
// Verify options file.
+ expect(optionsFileErrors, isNotNull);
expect(optionsFileErrors, isEmpty);
// Verify test file.
+ expect(testFileErrors, isNotNull);
expect(testFileErrors, isEmpty);
}
@@ -129,9 +134,11 @@ main() {
await waitForTasksFinished();
// Verify options file.
+ expect(optionsFileErrors, isNotNull);
expect(optionsFileErrors, isEmpty);
// Verify test file.
+ expect(testFileErrors, isNotNull);
expect(testFileErrors, isEmpty);
addOptionsFile('''
@@ -289,14 +296,15 @@ linter:
}
void verifyLintsEnabled(List<String> lints) {
- expect(testContext.analysisOptions.lint, true);
- var rules = getLints(testContext).map((rule) => rule.name);
+ AnalysisOptions options = analysisOptions;
+ expect(options.lint, true);
+ var rules = options.lintRules.map((rule) => rule.name);
expect(rules, unorderedEquals(lints));
}
verifyStrongMode({bool enabled}) {
// Verify strong-mode enabled.
- expect(testContext.analysisOptions.strongMode, enabled);
+ expect(analysisOptions.strongMode, enabled);
if (enabled) {
// Should produce a type warning.
@@ -313,11 +321,35 @@ linter:
@reflectiveTest
class NewAnalysisOptionsFileNotificationTest
extends AnalysisOptionsFileNotificationTest {
+ @override
String get optionsFilePath => '$projectPath/analysis_options.yaml';
}
@reflectiveTest
+class NewAnalysisOptionsFileNotificationTest_Driver
+ extends NewAnalysisOptionsFileNotificationTest {
+ @override
+ void setUp() {
+ enableNewAnalysisDriver = true;
+ generateSummaryFiles = true;
+ super.setUp();
+ }
+}
+
+@reflectiveTest
class OldAnalysisOptionsFileNotificationTest
extends AnalysisOptionsFileNotificationTest {
+ @override
String get optionsFilePath => '$projectPath/.analysis_options';
}
+
+@reflectiveTest
+class OldAnalysisOptionsFileNotificationTest_Driver
+ extends OldAnalysisOptionsFileNotificationTest {
+ @override
+ void setUp() {
+ enableNewAnalysisDriver = true;
+ generateSummaryFiles = true;
+ super.setUp();
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698