Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2562083002: Get some tests running using the analysis driver (Closed)

Created:
4 years ago by Brian Wilkerson
Modified:
4 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+448 lines, -117 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 3 chunks +2 lines, -8 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 3 chunks +52 lines, -9 lines 0 comments Download
M pkg/analysis_server/lib/src/single_context_manager.dart View 1 chunk +6 lines, -0 lines 0 comments Download
A pkg/analysis_server/lib/src/utilities/null_string_sink.dart View 1 chunk +13 lines, -0 lines 2 comments Download
M pkg/analysis_server/test/analysis/notification_analysis_options_test.dart View 7 chunks +39 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 3 chunks +9 lines, -1 line 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 31 chunks +321 lines, -91 lines 0 comments Download
M pkg/analysis_server/test/single_context_manager_test.dart View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
4 years ago (2016-12-09 15:31:11 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2562083002/diff/1/pkg/analysis_server/lib/src/utilities/null_string_sink.dart File pkg/analysis_server/lib/src/utilities/null_string_sink.dart (right): https://codereview.chromium.org/2562083002/diff/1/pkg/analysis_server/lib/src/utilities/null_string_sink.dart#newcode1 pkg/analysis_server/lib/src/utilities/null_string_sink.dart:1: // Copyright (c) 2014, the Dart project authors. ...
4 years ago (2016-12-09 16:28:22 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2562083002/diff/1/pkg/analysis_server/lib/src/utilities/null_string_sink.dart File pkg/analysis_server/lib/src/utilities/null_string_sink.dart (right): https://codereview.chromium.org/2562083002/diff/1/pkg/analysis_server/lib/src/utilities/null_string_sink.dart#newcode1 pkg/analysis_server/lib/src/utilities/null_string_sink.dart:1: // Copyright (c) 2014, the Dart project authors. Please ...
4 years ago (2016-12-09 16:32:39 UTC) #4
Brian Wilkerson
4 years ago (2016-12-09 16:32:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c99adefae7fead6acfeb99aac925563185e5c78f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698