Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Side by Side Diff: build/config/android/rules.gni

Issue 2562063003: Add incremental_apk_by_default GN arg. (Closed)
Patch Set: Add incremental_apk_by_default gn arg. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/android/internal_rules.gni ('k') | testing/test.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Do not add any imports to non-//build directories here. 5 # Do not add any imports to non-//build directories here.
6 # Some projects (e.g. V8) do not have non-build directories DEPS'ed in. 6 # Some projects (e.g. V8) do not have non-build directories DEPS'ed in.
7 import("//build/config/android/config.gni") 7 import("//build/config/android/config.gni")
8 import("//build/config/android/internal_rules.gni") 8 import("//build/config/android/internal_rules.gni")
9 import("//build/config/compiler/compiler.gni") 9 import("//build/config/compiler/compiler.gni")
10 import("//build/config/dcheck_always_on.gni") 10 import("//build/config/dcheck_always_on.gni")
(...skipping 2179 matching lines...) Expand 10 before | Expand all | Expand 10 after
2190 } 2190 }
2191 if (_create_language_splits) { 2191 if (_create_language_splits) {
2192 args += [ "--split=${_rebased_apk_path_no_ext}-language-*.apk" ] 2192 args += [ "--split=${_rebased_apk_path_no_ext}-language-*.apk" ]
2193 } 2193 }
2194 if (_load_library_from_apk) { 2194 if (_load_library_from_apk) {
2195 args += [ "--dont-even-try=Incremental builds do not work with load_libr ary_from_apk. Try setting is_component_build=true in your GN args." ] 2195 args += [ "--dont-even-try=Incremental builds do not work with load_libr ary_from_apk. Try setting is_component_build=true in your GN args." ]
2196 } 2196 }
2197 } 2197 }
2198 2198
2199 group(target_name) { 2199 group(target_name) {
2200 forward_variables_from(invoker, 2200 if (incremental_apk_by_default) {
2201 [ 2201 deps = [
2202 "data", 2202 ":${target_name}_incremental",
2203 "data_deps", 2203 ]
2204 ]) 2204 } else {
2205 public_deps = _final_deps 2205 forward_variables_from(invoker,
2206 [
2207 "data",
2208 "data_deps",
2209 ])
2210 public_deps = _final_deps
2206 2211
2207 # Make the proguard .mapping file easy to find by putting it beside the .a pk. 2212 # Make the proguard .mapping file easy to find by putting it beside the .apk.
2208 if (_proguard_enabled) { 2213 if (_proguard_enabled) {
2209 deps = [ 2214 deps = [
2210 ":$_copy_proguard_mapping_target", 2215 ":$_copy_proguard_mapping_target",
2211 ] 2216 ]
2217 }
2212 } 2218 }
2213 } 2219 }
2214 group("${target_name}_incremental") { 2220 group("${target_name}_incremental") {
2215 forward_variables_from(invoker, 2221 forward_variables_from(invoker,
2216 [ 2222 [
2217 "data", 2223 "data",
2218 "data_deps", 2224 "data_deps",
2219 ]) 2225 ])
2220 if (!defined(data_deps)) { 2226 if (!defined(data_deps)) {
2221 data_deps = [] 2227 data_deps = []
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
2322 deps = [] 2328 deps = []
2323 data_deps = [] 2329 data_deps = []
2324 forward_variables_from(invoker, "*") 2330 forward_variables_from(invoker, "*")
2325 install_script_name = _install_script_name 2331 install_script_name = _install_script_name
2326 deps += [ "//testing/android/broker:broker_java" ] 2332 deps += [ "//testing/android/broker:broker_java" ]
2327 data_deps += [ 2333 data_deps += [
2328 "//build/android/pylib/device/commands", 2334 "//build/android/pylib/device/commands",
2329 "//tools/android/forwarder2", 2335 "//tools/android/forwarder2",
2330 "//tools/android/md5sum", 2336 "//tools/android/md5sum",
2331 ] 2337 ]
2332 if (defined(invoker.additional_apks)) {
2333 data_deps += invoker.additional_apks
2334 }
2335 2338
2336 if (defined(invoker.proguard_enabled) && invoker.proguard_enabled) { 2339 if (defined(invoker.proguard_enabled) && invoker.proguard_enabled) {
2337 # When ProGuard is on, we use ProGuard to combine the under test java 2340 # When ProGuard is on, we use ProGuard to combine the under test java
2338 # code and the test java code. This is to allow us to apply all ProGuard 2341 # code and the test java code. This is to allow us to apply all ProGuard
2339 # optimizations that we ship with, but not have them break tests. The 2342 # optimizations that we ship with, but not have them break tests. The
2340 # apk under test will still have the same resources, assets, and 2343 # apk under test will still have the same resources, assets, and
2341 # manifest, all of which are the ones used in the tests. 2344 # manifest, all of which are the ones used in the tests.
2342 if (!defined(invoker.proguard_configs)) { 2345 if (!defined(invoker.proguard_configs)) {
2343 proguard_configs = [] 2346 proguard_configs = []
2344 } 2347 }
2345 proguard_configs += [ "//testing/android/proguard_for_test.flags" ] 2348 proguard_configs += [ "//testing/android/proguard_for_test.flags" ]
2346 } 2349 }
2347 2350
2348 dist_ijar_path = _dist_ijar_path 2351 dist_ijar_path = _dist_ijar_path
2349 if (defined(invoker.run_findbugs_override)) { 2352 if (defined(invoker.run_findbugs_override)) {
2350 # Only allow findbugs when there are java files. 2353 # Only allow findbugs when there are java files.
2351 run_findbugs_override = 2354 run_findbugs_override =
2352 invoker.run_findbugs_override && defined(invoker.java_files) 2355 invoker.run_findbugs_override && defined(invoker.java_files)
2353 } 2356 }
2354 } 2357 }
2355 2358
2356 group(target_name) { 2359 group(target_name) {
2357 public_deps = [ 2360 if (incremental_apk_by_default) {
2358 ":$_apk_target_name", 2361 deps = [
2359 ":$_test_runner_target_name", 2362 ":${target_name}_incremental",
2363 ]
2364 } else {
2365 public_deps = [
2366 ":$_apk_target_name",
2367 ":$_test_runner_target_name",
2360 2368
2361 # Required by test runner to enumerate test list. 2369 # Required by test runner to enumerate test list.
2362 ":${_apk_target_name}_dist_ijar", 2370 ":${_apk_target_name}_dist_ijar",
2363 ] 2371 ]
2364 if (defined(invoker.apk_under_test)) { 2372 data_deps = []
2365 public_deps += [ invoker.apk_under_test ] 2373 if (defined(invoker.apk_under_test)) {
2374 data_deps += [ invoker.apk_under_test ]
2375 }
2376 if (defined(invoker.additional_apks)) {
2377 data_deps += invoker.additional_apks
2378 }
2366 } 2379 }
2367 } 2380 }
2368 2381
2369 # TODO: Delete once recipes no longer use this target. 2382 # TODO: Delete once recipes no longer use this target.
2370 group("${target_name}_run") { 2383 group("${target_name}_run") {
2371 public_deps = [ 2384 public_deps = [
2372 ":${invoker.target_name}", 2385 ":${invoker.target_name}",
2373 ] 2386 ]
2374 } 2387 }
2375 group("${target_name}_incremental") { 2388 group("${target_name}_incremental") {
2376 public_deps = [ 2389 public_deps = [
2377 ":${_apk_target_name}_dist_ijar", 2390 ":${_apk_target_name}_dist_ijar",
2378 ":${_apk_target_name}_incremental", 2391 ":${_apk_target_name}_incremental",
2379 ":${_test_runner_target_name}_incremental", 2392 ":${_test_runner_target_name}_incremental",
2380 ] 2393 ]
2394 data_deps = []
2395 if (defined(invoker.additional_apks)) {
2396 foreach(_additional_apk, invoker.additional_apks) {
2397 data_deps += [ "${_additional_apk}_incremental" ]
2398 }
2399 }
2400
2381 if (defined(invoker.apk_under_test)) { 2401 if (defined(invoker.apk_under_test)) {
2382 public_deps += [ "${invoker.apk_under_test}_incremental" ] 2402 data_deps += [ "${invoker.apk_under_test}_incremental" ]
2383 } 2403 }
2384 } 2404 }
2385 } 2405 }
2386 2406
2387 # Declare an Android gtest apk 2407 # Declare an Android gtest apk
2388 # 2408 #
2389 # This target creates an Android apk for running gtest-based unittests. 2409 # This target creates an Android apk for running gtest-based unittests.
2390 # 2410 #
2391 # Variables 2411 # Variables
2392 # deps: Specifies the dependencies of this target. These will be passed to 2412 # deps: Specifies the dependencies of this target. These will be passed to
(...skipping 389 matching lines...) Expand 10 before | Expand all | Expand 10 after
2782 # because in practice they seem to contain classes required to be in the 2802 # because in practice they seem to contain classes required to be in the
2783 # classpath. 2803 # classpath.
2784 deps += _subjar_targets 2804 deps += _subjar_targets
2785 } 2805 }
2786 if (defined(_res_target_name)) { 2806 if (defined(_res_target_name)) {
2787 deps += [ ":$_res_target_name" ] 2807 deps += [ ":$_res_target_name" ]
2788 } 2808 }
2789 } 2809 }
2790 } 2810 }
2791 } 2811 }
OLDNEW
« no previous file with comments | « build/config/android/internal_rules.gni ('k') | testing/test.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698