Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: build/config/android/internal_rules.gni

Issue 2562063003: Add incremental_apk_by_default GN arg. (Closed)
Patch Set: Remove error formatting Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/android/config.gni ('k') | build/config/android/rules.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Do not add any imports to non-//build directories here. 5 # Do not add any imports to non-//build directories here.
6 # Some projects (e.g. V8) do not have non-build directories DEPS'ed in. 6 # Some projects (e.g. V8) do not have non-build directories DEPS'ed in.
7 import("//build_overrides/build.gni") 7 import("//build_overrides/build.gni")
8 import("//build/config/android/config.gni") 8 import("//build/config/android/config.gni")
9 import("//build/config/dcheck_always_on.gni") 9 import("//build/config/dcheck_always_on.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
(...skipping 280 matching lines...) Expand 10 before | Expand all | Expand 10 after
291 rebase_path(invoker.proguard_info, root_build_dir), 291 rebase_path(invoker.proguard_info, root_build_dir),
292 ] 292 ]
293 } 293 }
294 294
295 if (defined(invoker.apk_path)) { 295 if (defined(invoker.apk_path)) {
296 _rebased_apk_path = rebase_path(invoker.apk_path, root_build_dir) 296 _rebased_apk_path = rebase_path(invoker.apk_path, root_build_dir)
297 _rebased_incremental_apk_path = 297 _rebased_incremental_apk_path =
298 rebase_path(invoker.incremental_apk_path, root_build_dir) 298 rebase_path(invoker.incremental_apk_path, root_build_dir)
299 _rebased_incremental_install_script_path = 299 _rebased_incremental_install_script_path =
300 rebase_path(invoker.incremental_install_script_path, root_build_dir) 300 rebase_path(invoker.incremental_install_script_path, root_build_dir)
301 _incremental_allowed =
302 defined(invoker.incremental_allowed) && invoker.incremental_allowed
301 args += [ "--apk-path=$_rebased_apk_path" ] 303 args += [ "--apk-path=$_rebased_apk_path" ]
302 args += [ "--incremental-apk-path=$_rebased_incremental_apk_path" ]
303 args += [ "--incremental-install-script-path=$_rebased_incremental_insta ll_script_path" ] 304 args += [ "--incremental-install-script-path=$_rebased_incremental_insta ll_script_path" ]
305
306 assert(_rebased_incremental_apk_path != "") # Mark as used.
307 if (_incremental_allowed) {
308 args += [ "--incremental-apk-path=$_rebased_incremental_apk_path" ]
309 }
304 } 310 }
305 } 311 }
306 312
307 if (defined(invoker.java_sources_file)) { 313 if (defined(invoker.java_sources_file)) {
308 args += [ 314 args += [
309 "--java-sources-file", 315 "--java-sources-file",
310 rebase_path(invoker.java_sources_file, root_build_dir), 316 rebase_path(invoker.java_sources_file, root_build_dir),
311 ] 317 ]
312 } 318 }
313 if (defined(invoker.srcjar)) { 319 if (defined(invoker.srcjar)) {
(...skipping 239 matching lines...) Expand 10 before | Expand all | Expand 10 after
553 559
554 if (defined(invoker.additional_apks)) { 560 if (defined(invoker.additional_apks)) {
555 foreach(additional_apk, invoker.additional_apks) { 561 foreach(additional_apk, invoker.additional_apks) {
556 deps += [ "${additional_apk}__build_config" ] 562 deps += [ "${additional_apk}__build_config" ]
557 _build_config = get_label_info(additional_apk, "target_gen_dir") + "/" + 563 _build_config = get_label_info(additional_apk, "target_gen_dir") + "/" +
558 get_label_info(additional_apk, "name") + ".build_config" 564 get_label_info(additional_apk, "name") + ".build_config"
559 _rebased_build_config = rebase_path(_build_config, root_build_dir) 565 _rebased_build_config = rebase_path(_build_config, root_build_dir)
560 test_runner_args += [ 566 test_runner_args += [
561 "--additional-apk", 567 "--additional-apk",
562 "@FileArg($_rebased_build_config:deps_info:apk_path)", 568 "@FileArg($_rebased_build_config:deps_info:apk_path)",
569 "--additional-apk-incremental",
570 "@FileArg($_rebased_build_config:deps_info:incremental_apk_path)",
563 ] 571 ]
564 } 572 }
565 } 573 }
566 if (defined(invoker.shard_timeout)) { 574 if (defined(invoker.shard_timeout)) {
567 test_runner_args += [ "--shard-timeout=${invoker.shard_timeout}" ] 575 test_runner_args += [ "--shard-timeout=${invoker.shard_timeout}" ]
568 } 576 }
569 if (_incremental_install) { 577 if (_incremental_install) {
570 test_runner_args += [ 578 test_runner_args += [
571 "--test-apk-incremental-install-script", 579 "--test-apk-incremental-install-script",
572 "@FileArg($_rebased_apk_build_config:deps_info:incremental_install_scrip t_path)", 580 "@FileArg($_rebased_apk_build_config:deps_info:incremental_install_scrip t_path)",
(...skipping 2215 matching lines...) Expand 10 before | Expand all | Expand 10 after
2788 rebase_path(root_build_dir, root_build_dir), 2796 rebase_path(root_build_dir, root_build_dir),
2789 "--packed-libraries-dir", 2797 "--packed-libraries-dir",
2790 rebase_path(_packed_libraries_dir, root_build_dir), 2798 rebase_path(_packed_libraries_dir, root_build_dir),
2791 "--libraries=${invoker.libraries_filearg}", 2799 "--libraries=${invoker.libraries_filearg}",
2792 "--filelistjson", 2800 "--filelistjson",
2793 rebase_path(invoker.file_list_json, root_build_dir), 2801 rebase_path(invoker.file_list_json, root_build_dir),
2794 ] 2802 ]
2795 } 2803 }
2796 } 2804 }
2797 } 2805 }
OLDNEW
« no previous file with comments | « build/config/android/config.gni ('k') | build/config/android/rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698