Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: third_party/WebKit/public/platform/WebMediaPlayer.h

Issue 2562003003: Fix the size of video textures uploaded to WebGL. (Closed)
Patch Set: Rebased. Fixed Android build. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/WebMediaPlayer.h
diff --git a/third_party/WebKit/public/platform/WebMediaPlayer.h b/third_party/WebKit/public/platform/WebMediaPlayer.h
index 370c523b3e305502b6f660755ed29ba41538a44b..bccb8456bc3b68bf93e37c99a5cc85d901068f43 100644
--- a/third_party/WebKit/public/platform/WebMediaPlayer.h
+++ b/third_party/WebKit/public/platform/WebMediaPlayer.h
@@ -181,16 +181,21 @@ class WebMediaPlayer {
virtual void paint(WebCanvas*, const WebRect&, SkPaint&) = 0;
- // TODO(dshwang): remove non-|target| version. crbug.com/349871
+ // TODO(kbr): remove non-|target| version. crbug.com/349871
+ //
+ // Do a GPU-GPU texture copy of the natural size of the current
+ // video frame to |texture|. Caller is responsible for allocating
+ // |texture| with the appropriate size. If the copy is impossible or
+ // fails, it returns false.
virtual bool copyVideoTextureToPlatformTexture(gpu::gles2::GLES2Interface*,
unsigned texture,
- unsigned internalFormat,
- unsigned type,
bool premultiplyAlpha,
bool flipY) {
return false;
}
+ // TODO(kbr): when updating calling code to use this, remove the
+ // |internalFormat| and |type| parameters. crbug.com/349871
// Do a GPU-GPU textures copy. If the copy is impossible or fails, it returns
// false.
virtual bool copyVideoTextureToPlatformTexture(gpu::gles2::GLES2Interface*,
« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698