Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Unified Diff: runtime/vm/debugger_api_impl_test.cc

Issue 25620003: Two of these test cases fail Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger_api_impl_test.cc
diff --git a/runtime/vm/debugger_api_impl_test.cc b/runtime/vm/debugger_api_impl_test.cc
index 5bd208444a51611dd1a948f45f72664ff547877a..b2891e650b777365d59a5ac13d5e2c057ed192f7 100644
--- a/runtime/vm/debugger_api_impl_test.cc
+++ b/runtime/vm/debugger_api_impl_test.cc
@@ -1522,6 +1522,11 @@ void TestEvaluateHandler(Dart_IsolateId isolate_id,
EXPECT(Dart_IsInteger(h));
EXPECT_EQ(10, ToInt64(h));
+ // Check that we return an error on invalid expressions.
+ EXPECT(Dart_IsError(Dart_EvaluateExpr(p, NewString("1; 2"))));
+ EXPECT(Dart_IsError(Dart_EvaluateExpr(p, NewString("int x"))));
+ EXPECT(Dart_IsError(Dart_EvaluateExpr(p, NewString("var x"))));
+
breakpoint_hit = true;
breakpoint_hit_counter++;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698