[rac] Use i18n address inputs with --enable-autofill-address-i18n flag

chrome/browser/ui/autofill/autofill_dialog_controller_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_
 #define CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_
 
 #include <set>
 #include <vector>
 
@@ skipping 41 matching lines @@
 }
 
 namespace autofill {
 
 class AutofillDataModel;
 class AutofillDialogView;
 class AutofillPopupControllerImpl;
 class DataModelWrapper;
 class TestableAutofillDialogView;
 
+namespace common {
+class AutofillDialogInput;
+}
+
 namespace risk {
 class Fingerprint;
 }
 
 namespace wallet {
 class WalletSigninHelper;
 }
 
 // This class drives the dialog that appears when a site uses the imperative
 // autocomplete API to fill out a form.
@@ skipping 664 matching lines @@
   base::OneShotTimer<AutofillDialogControllerImpl> card_scrambling_delay_;
   base::RepeatingTimer<AutofillDialogControllerImpl> card_scrambling_refresher_;
 
   // An animation which controls the background fade when the card is done
   // scrambling.
   gfx::LinearAnimation card_generated_animation_;
 
   // A username string we display in the card scrambling/generated overlay.
   base::string16 submitted_cardholder_name_;
 
+  // An object for building inputs for autofill sections.
+  scoped_ptr<common::AutofillDialogInput> inputs_builder_;

[Evan Stade, 2013/10/02 00:57:19]

I don't see any reason for this to be a member variable. Instead of creating an
interface, can you expose the BuildInputs methods as static utilities, with the
check inside each one proxying to other static functions?

[please use gerrit instead, 2013/10/02 18:21:50]

I've decided to make AutofillDialogControllerImpl own the AutofillDialogInput
object because AutofillDialogInputI18n will own the libaddressinput context. It
makes sense to keep one libaddressinput context per address input form.
AutofillDialogControllerImpl has two address input forms, actually, so I think
that it needs two instances of AutofillDialogInput. I prefer to not have a
single static libaddressinput context be used by multiple address forms.

[Evan Stade, 2013/10/02 20:27:19]

what state is the object going to hold?

+
   DISALLOW_COPY_AND_ASSIGN(AutofillDialogControllerImpl);
 };
 
 }  // namespace autofill
 
 #endif  // CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_