Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/views/view.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/base/template_expressions.cc ('K') | « ui/views/test/views_test_base.cc ('k') | ui/views/widget/desktop_aura/desktop_factory_ozone.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/view.cc
diff --git a/ui/views/view.cc b/ui/views/view.cc
index 92223157d4c8671aaa2c55aab4c006d1ee25b265..8912f621d765b861b107639574f6fd7bc088990f 100644
--- a/ui/views/view.cc
+++ b/ui/views/view.cc
@@ -159,7 +159,8 @@ void View::AddChildView(View* view) {
}
void View::AddChildViewAt(View* view, int index) {
- CHECK_NE(view, this) << "You cannot add a view as its own child";
+ // You cannot add a view as its own child
+ CHECK_NE(view, this);
DCHECK_GE(index, 0);
DCHECK_LE(index, child_count());
« ui/base/template_expressions.cc ('K') | « ui/views/test/views_test_base.cc ('k') | ui/views/widget/desktop_aura/desktop_factory_ozone.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698