base: Remove the string logging from CHECK().

tools/gn/ninja_target_writer.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/gn/ninja_target_writer.h"
 
 #include <sstream>
 
 #include "base/files/file_util.h"
 #include "base/strings/string_util.h"
@@ skipping 72 matching lines @@
     NinjaActionTargetWriter writer(target, rules);
     writer.Run();
   } else if (target->output_type() == Target::GROUP) {
     NinjaGroupTargetWriter writer(target, rules);
     writer.Run();
   } else if (target->IsBinary()) {
     needs_file_write = true;
     NinjaBinaryTargetWriter writer(target, rules);
     writer.Run();
   } else {
-    CHECK(0) << "Output type of target not handled.";
+    // Output type of target not handled.
+    CHECK(0);
   }
 
   if (needs_file_write) {
     // Write the ninja file.
     SourceFile ninja_file = GetNinjaFileForTarget(target);
     base::FilePath full_ninja_file =
         settings->build_settings()->GetFullPath(ninja_file);
     base::CreateDirectory(full_ninja_file.DirName());
     WriteFileIfChanged(full_ninja_file, rules.str(), nullptr);
 
@@ skipping 70 matching lines @@
   }
 
   // If we wrote any vars, separate them from the rest of the file that follows
   // with a blank line.
   if (written_anything)
     out_ << std::endl;
 }
 
 OutputFile NinjaTargetWriter::WriteInputDepsStampAndGetDep(
     const std::vector<const Target*>& extra_hard_deps) const {
-  CHECK(target_->toolchain())
-      << "Toolchain not set on target "
-      << target_->label().GetUserVisibleName(true);
+  // Toolchain not set on target |target_->label().GetUserVisibleName(true)|.
+  CHECK(target_->toolchain());
 
   // ----------
   // Collect all input files that are input deps of this target. Knowing the
   // number before writing allows us to either skip writing the input deps
   // stamp or optimize it. Use pointers to avoid copies here.
   std::vector<const SourceFile*> input_deps_sources;
   input_deps_sources.reserve(32);
 
   // Actions get implicit dependencies on the script itself.
   if (target_->output_type() == Target::ACTION ||
@@ skipping 98 matching lines @@
   return input_stamp_file;
 }
 
 void NinjaTargetWriter::WriteStampForTarget(
     const std::vector<OutputFile>& files,
     const std::vector<OutputFile>& order_only_deps) {
   const OutputFile& stamp_file = target_->dependency_output_file();
 
   // First validate that the target's dependency is a stamp file. Otherwise,
   // we shouldn't have gotten here!
-  CHECK(base::EndsWith(stamp_file.value(), ".stamp",
-                       base::CompareCase::INSENSITIVE_ASCII))
+  LOG_IF(FATAL, !base::EndsWith(stamp_file.value(), ".stamp",
+                                base::CompareCase::INSENSITIVE_ASCII))
       << "Output should end in \".stamp\" for stamp file output. Instead got: "
       << "\"" << stamp_file.value() << "\"";
 
   out_ << "build ";
   path_output_.WriteFile(out_, stamp_file);
 
   out_ << ": "
        << GetNinjaRulePrefixForToolchain(settings_)
        << Toolchain::ToolTypeToName(Toolchain::TYPE_STAMP);
   path_output_.WriteFiles(out_, files);
 
   if (!order_only_deps.empty()) {
     out_ << " ||";
     path_output_.WriteFiles(out_, order_only_deps);
   }
   out_ << std::endl;
 }