Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1140)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/BindingSecurity.cpp

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after
205 return false; 205 return false;
206 return canAccessFrame(accessingWindow, 206 return canAccessFrame(accessingWindow,
207 target->securityContext()->getSecurityOrigin(), 207 target->securityContext()->getSecurityOrigin(),
208 target->domWindow(), reportingOption); 208 target->domWindow(), reportingOption);
209 } 209 }
210 210
211 bool BindingSecurity::shouldAllowAccessToDetachedWindow( 211 bool BindingSecurity::shouldAllowAccessToDetachedWindow(
212 const LocalDOMWindow* accessingWindow, 212 const LocalDOMWindow* accessingWindow,
213 const DOMWindow* target, 213 const DOMWindow* target,
214 ExceptionState& exceptionState) { 214 ExceptionState& exceptionState) {
215 CHECK(target && !target->frame()) 215 // This version of shouldAllowAccessToFrame() must be used only for detached
216 << "This version of shouldAllowAccessToFrame() must be used only for " 216 // windows.
217 << "detached windows."; 217 CHECK(target && !target->frame());
218 if (!target->document()) 218 if (!target->document())
219 return false; 219 return false;
220 return canAccessFrame(accessingWindow, 220 return canAccessFrame(accessingWindow,
221 target->document()->getSecurityOrigin(), target, 221 target->document()->getSecurityOrigin(), target,
222 exceptionState); 222 exceptionState);
223 } 223 }
224 224
225 } // namespace blink 225 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698