Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Side by Side Diff: remoting/host/security_key/security_key_ipc_server_impl.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "remoting/host/security_key/security_key_ipc_server_impl.h" 5 #include "remoting/host/security_key/security_key_ipc_server_impl.h"
6 6
7 #include <cstdint> 7 #include <cstdint>
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 10
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 return false; 133 return false;
134 } 134 }
135 135
136 bool handled = true; 136 bool handled = true;
137 IPC_BEGIN_MESSAGE_MAP(SecurityKeyIpcServerImpl, message) 137 IPC_BEGIN_MESSAGE_MAP(SecurityKeyIpcServerImpl, message)
138 IPC_MESSAGE_HANDLER(ChromotingRemoteSecurityKeyToNetworkMsg_Request, 138 IPC_MESSAGE_HANDLER(ChromotingRemoteSecurityKeyToNetworkMsg_Request,
139 OnSecurityKeyRequest) 139 OnSecurityKeyRequest)
140 IPC_MESSAGE_UNHANDLED(handled = false) 140 IPC_MESSAGE_UNHANDLED(handled = false)
141 IPC_END_MESSAGE_MAP() 141 IPC_END_MESSAGE_MAP()
142 142
143 CHECK(handled) << "Received unexpected IPC type: " << message.type(); 143 // Received unexpected IPC type.
144 CHECK(handled);
144 return handled; 145 return handled;
145 } 146 }
146 147
147 void SecurityKeyIpcServerImpl::OnChannelConnected(int32_t peer_pid) { 148 void SecurityKeyIpcServerImpl::OnChannelConnected(int32_t peer_pid) {
148 DCHECK(thread_checker_.CalledOnValidThread()); 149 DCHECK(thread_checker_.CalledOnValidThread());
149 150
150 if (!connect_callback_.is_null()) { 151 if (!connect_callback_.is_null()) {
151 base::ResetAndReturn(&connect_callback_).Run(); 152 base::ResetAndReturn(&connect_callback_).Run();
152 } 153 }
153 154
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 connection_close_pending_ = false; 209 connection_close_pending_ = false;
209 } 210 }
210 // Close the underlying mojo connection. 211 // Close the underlying mojo connection.
211 if (!mojo_peer_token_.empty()) { 212 if (!mojo_peer_token_.empty()) {
212 mojo::edk::ClosePeerConnection(mojo_peer_token_); 213 mojo::edk::ClosePeerConnection(mojo_peer_token_);
213 mojo_peer_token_.clear(); 214 mojo_peer_token_.clear();
214 } 215 }
215 } 216 }
216 217
217 } // namespace remoting 218 } // namespace remoting
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698