Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Side by Side Diff: mojo/public/cpp/bindings/tests/binding_callback_unittest.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdint.h> 5 #include <stdint.h>
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 last_server_value_seen_ = x; 82 last_server_value_seen_ = x;
83 *callback_saved_ = callback; 83 *callback_saved_ = callback;
84 if (!closure_.is_null()) { 84 if (!closure_.is_null()) {
85 closure_.Run(); 85 closure_.Run();
86 closure_.Reset(); 86 closure_.Reset();
87 } 87 }
88 } 88 }
89 89
90 void EchoString(const std::string& a, 90 void EchoString(const std::string& a,
91 const EchoStringCallback& callback) override { 91 const EchoStringCallback& callback) override {
92 CHECK(false) << "Not implemented."; 92 // Not implemented.
93 CHECK(false);
93 } 94 }
94 95
95 void EchoStrings(const std::string& a, 96 void EchoStrings(const std::string& a,
96 const std::string& b, 97 const std::string& b,
97 const EchoStringsCallback& callback) override { 98 const EchoStringsCallback& callback) override {
98 CHECK(false) << "Not implemented."; 99 // Not implemented.
100 CHECK(false);
99 } 101 }
100 102
101 void EchoMessagePipeHandle( 103 void EchoMessagePipeHandle(
102 ScopedMessagePipeHandle a, 104 ScopedMessagePipeHandle a,
103 const EchoMessagePipeHandleCallback& callback) override { 105 const EchoMessagePipeHandleCallback& callback) override {
104 CHECK(false) << "Not implemented."; 106 // Not implemented.
107 CHECK(false);
105 } 108 }
106 109
107 void EchoEnum(sample::Enum a, const EchoEnumCallback& callback) override { 110 void EchoEnum(sample::Enum a, const EchoEnumCallback& callback) override {
108 CHECK(false) << "Not implemented."; 111 // Not implemented.
112 CHECK(false);
109 } 113 }
110 114
111 void resetLastServerValueSeen() { last_server_value_seen_ = 0; } 115 void resetLastServerValueSeen() { last_server_value_seen_ = 0; }
112 116
113 int32_t last_server_value_seen() const { return last_server_value_seen_; } 117 int32_t last_server_value_seen() const { return last_server_value_seen_; }
114 118
115 void set_closure(const base::Closure& closure) { closure_ = closure; } 119 void set_closure(const base::Closure& closure) { closure_ = closure; }
116 120
117 private: 121 private:
118 int32_t last_server_value_seen_; 122 int32_t last_server_value_seen_;
(...skipping 218 matching lines...) Expand 10 before | Expand all | Expand 10 after
337 regex.clear(); 341 regex.clear();
338 #endif // OS_WIN 342 #endif // OS_WIN
339 EXPECT_DEATH_IF_SUPPORTED(server_impl.DeleteCallback(), regex.c_str()); 343 EXPECT_DEATH_IF_SUPPORTED(server_impl.DeleteCallback(), regex.c_str());
340 #endif // (!defined(NDEBUG) || defined(DCHECK_ALWAYS_ON)) && 344 #endif // (!defined(NDEBUG) || defined(DCHECK_ALWAYS_ON)) &&
341 // !defined(OS_ANDROID) 345 // !defined(OS_ANDROID)
342 } 346 }
343 347
344 } // namespace 348 } // namespace
345 } // namespace test 349 } // namespace test
346 } // namespace mojo 350 } // namespace mojo
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698