Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Side by Side Diff: ios/chrome/browser/signin/browser_state_data_remover.mm

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/chrome/browser/signin/browser_state_data_remover.h" 5 #import "ios/chrome/browser/signin/browser_state_data_remover.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/threading/thread_task_runner_handle.h" 8 #include "base/threading/thread_task_runner_handle.h"
9 #include "components/prefs/pref_service.h" 9 #include "components/prefs/pref_service.h"
10 #include "components/signin/core/common/signin_pref_names.h" 10 #include "components/signin/core/common/signin_pref_names.h"
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 UIWindow* mainWindow = [[UIApplication sharedApplication] keyWindow]; 57 UIWindow* mainWindow = [[UIApplication sharedApplication] keyWindow];
58 DCHECK(mainWindow); 58 DCHECK(mainWindow);
59 [mainWindow chromeExecuteCommand:command]; 59 [mainWindow chromeExecuteCommand:command];
60 } 60 }
61 61
62 void BrowserStateDataRemover::NotifyWithDetails( 62 void BrowserStateDataRemover::NotifyWithDetails(
63 const IOSChromeBrowsingDataRemover::NotificationDetails& details) { 63 const IOSChromeBrowsingDataRemover::NotificationDetails& details) {
64 // Remove bookmarks once all browsing data was removed. 64 // Remove bookmarks once all browsing data was removed.
65 // Removal of browsing data waits for the bookmark model to be loaded, so 65 // Removal of browsing data waits for the bookmark model to be loaded, so
66 // there should be no issue calling the function here. 66 // there should be no issue calling the function here.
67 CHECK(RemoveAllUserBookmarksIOS(browser_state_)) 67 // Failed to remove all user bookmarks.
68 << "Failed to remove all user bookmarks."; 68 CHECK(RemoveAllUserBookmarksIOS(browser_state_));
69 69
70 if (details.removal_mask != kRemoveAllDataMask) { 70 if (details.removal_mask != kRemoveAllDataMask) {
71 NOTREACHED() << "Unexpected partial remove browsing data request " 71 NOTREACHED() << "Unexpected partial remove browsing data request "
72 << "(removal mask = " << details.removal_mask << ")"; 72 << "(removal mask = " << details.removal_mask << ")";
73 return; 73 return;
74 } 74 }
75 75
76 if (forget_last_username_) { 76 if (forget_last_username_) {
77 browser_state_->GetPrefs()->ClearPref(prefs::kGoogleServicesLastAccountId); 77 browser_state_->GetPrefs()->ClearPref(prefs::kGoogleServicesLastAccountId);
78 browser_state_->GetPrefs()->ClearPref(prefs::kGoogleServicesLastUsername); 78 browser_state_->GetPrefs()->ClearPref(prefs::kGoogleServicesLastUsername);
79 } 79 }
80 80
81 if (callback_) 81 if (callback_)
82 callback_.get()(); 82 callback_.get()();
83 83
84 base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, this); 84 base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, this);
85 } 85 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698