Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: content/renderer/render_widget.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_widget.h" 5 #include "content/renderer/render_widget.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/auto_reset.h" 10 #include "base/auto_reset.h"
(...skipping 638 matching lines...) Expand 10 before | Expand all | Expand 10 after
649 649
650 // If given a messsage without a routing ID, then assign our routing ID. 650 // If given a messsage without a routing ID, then assign our routing ID.
651 if (message->routing_id() == MSG_ROUTING_NONE) 651 if (message->routing_id() == MSG_ROUTING_NONE)
652 message->set_routing_id(routing_id_); 652 message->set_routing_id(routing_id_);
653 653
654 return RenderThread::Get()->Send(message); 654 return RenderThread::Get()->Send(message);
655 } 655 }
656 656
657 void RenderWidget::SendOrCrash(IPC::Message* message) { 657 void RenderWidget::SendOrCrash(IPC::Message* message) {
658 bool result = Send(message); 658 bool result = Send(message);
659 CHECK(closing_ || result) << "Failed to send message"; 659 // Failed to send message
660 CHECK(closing_ || result);
660 } 661 }
661 662
662 void RenderWidget::SetWindowRectSynchronously( 663 void RenderWidget::SetWindowRectSynchronously(
663 const gfx::Rect& new_window_rect) { 664 const gfx::Rect& new_window_rect) {
664 ResizeParams params; 665 ResizeParams params;
665 params.screen_info = screen_info_; 666 params.screen_info = screen_info_;
666 params.new_size = new_window_rect.size(); 667 params.new_size = new_window_rect.size();
667 params.physical_backing_size = 668 params.physical_backing_size =
668 gfx::ScaleToCeiledSize(new_window_rect.size(), device_scale_factor_); 669 gfx::ScaleToCeiledSize(new_window_rect.size(), device_scale_factor_);
669 params.visible_viewport_size = new_window_rect.size(); 670 params.visible_viewport_size = new_window_rect.size();
(...skipping 1579 matching lines...) Expand 10 before | Expand all | Expand 10 after
2249 // browser side (https://crbug.com/669219). 2250 // browser side (https://crbug.com/669219).
2250 // If there is no WebFrameWidget, then there will be no 2251 // If there is no WebFrameWidget, then there will be no
2251 // InputMethodControllers for a WebLocalFrame. 2252 // InputMethodControllers for a WebLocalFrame.
2252 return nullptr; 2253 return nullptr;
2253 } 2254 }
2254 return static_cast<blink::WebFrameWidget*>(GetWebWidget()) 2255 return static_cast<blink::WebFrameWidget*>(GetWebWidget())
2255 ->getActiveWebInputMethodController(); 2256 ->getActiveWebInputMethodController();
2256 } 2257 }
2257 2258
2258 } // namespace content 2259 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698