Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: content/public/browser/browser_child_process_host_iterator.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/public/browser/browser_child_process_host_iterator.h" 5 #include "content/public/browser/browser_child_process_host_iterator.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "content/browser/browser_child_process_host_impl.h" 8 #include "content/browser/browser_child_process_host_impl.h"
9 #include "content/public/browser/browser_thread.h" 9 #include "content/public/browser/browser_thread.h"
10 10
11 namespace content { 11 namespace content {
12 12
13 BrowserChildProcessHostIterator::BrowserChildProcessHostIterator() 13 BrowserChildProcessHostIterator::BrowserChildProcessHostIterator()
14 : all_(true), process_type_(PROCESS_TYPE_UNKNOWN) { 14 : all_(true), process_type_(PROCESS_TYPE_UNKNOWN) {
15 CHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)) << 15 // BrowserChildProcessHostIterator must be used on the IO thread.
16 "BrowserChildProcessHostIterator must be used on the IO thread."; 16 CHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
17 iterator_ = BrowserChildProcessHostImpl::GetIterator()->begin(); 17 iterator_ = BrowserChildProcessHostImpl::GetIterator()->begin();
18 } 18 }
19 19
20 BrowserChildProcessHostIterator::BrowserChildProcessHostIterator(int type) 20 BrowserChildProcessHostIterator::BrowserChildProcessHostIterator(int type)
21 : all_(false), process_type_(type) { 21 : all_(false), process_type_(type) {
22 CHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)) << 22 // BrowserChildProcessHostIterator must be used on the IO thread.
23 "BrowserChildProcessHostIterator must be used on the IO thread."; 23 CHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
24 DCHECK_NE(PROCESS_TYPE_RENDERER, type) << 24 DCHECK_NE(PROCESS_TYPE_RENDERER, type) <<
25 "BrowserChildProcessHostIterator doesn't work for renderer processes; " 25 "BrowserChildProcessHostIterator doesn't work for renderer processes; "
26 "try RenderProcessHost::AllHostsIterator() instead."; 26 "try RenderProcessHost::AllHostsIterator() instead.";
27 iterator_ = BrowserChildProcessHostImpl::GetIterator()->begin(); 27 iterator_ = BrowserChildProcessHostImpl::GetIterator()->begin();
28 if (!Done() && (*iterator_)->GetData().process_type != process_type_) 28 if (!Done() && (*iterator_)->GetData().process_type != process_type_)
29 ++(*this); 29 ++(*this);
30 } 30 }
31 31
32 BrowserChildProcessHostIterator::~BrowserChildProcessHostIterator() { 32 BrowserChildProcessHostIterator::~BrowserChildProcessHostIterator() {
33 } 33 }
(...skipping 27 matching lines...) Expand all
61 CHECK(!Done()); 61 CHECK(!Done());
62 return (*iterator_)->Send(message); 62 return (*iterator_)->Send(message);
63 } 63 }
64 64
65 BrowserChildProcessHostDelegate* 65 BrowserChildProcessHostDelegate*
66 BrowserChildProcessHostIterator::GetDelegate() { 66 BrowserChildProcessHostIterator::GetDelegate() {
67 return (*iterator_)->delegate(); 67 return (*iterator_)->delegate();
68 } 68 }
69 69
70 } // namespace content 70 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698