Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/render_frame_host_impl.h" 5 #include "content/browser/frame_host/render_frame_host_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 1937 matching lines...) Expand 10 before | Expand all | Expand 10 after
1948 const AXEventNotificationDetails& detail = details[i]; 1948 const AXEventNotificationDetails& detail = details[i];
1949 if (static_cast<int>(detail.event_type) < 0) 1949 if (static_cast<int>(detail.event_type) < 0)
1950 continue; 1950 continue;
1951 1951
1952 if (!ax_tree_for_testing_) { 1952 if (!ax_tree_for_testing_) {
1953 if (browser_accessibility_manager_) { 1953 if (browser_accessibility_manager_) {
1954 ax_tree_for_testing_.reset(new ui::AXTree( 1954 ax_tree_for_testing_.reset(new ui::AXTree(
1955 browser_accessibility_manager_->SnapshotAXTreeForTesting())); 1955 browser_accessibility_manager_->SnapshotAXTreeForTesting()));
1956 } else { 1956 } else {
1957 ax_tree_for_testing_.reset(new ui::AXTree()); 1957 ax_tree_for_testing_.reset(new ui::AXTree());
1958 CHECK(ax_tree_for_testing_->Unserialize(detail.update)) 1958 CHECK(ax_tree_for_testing_->Unserialize(detail.update));
1959 << ax_tree_for_testing_->error();
1960 } 1959 }
1961 } else { 1960 } else {
1962 CHECK(ax_tree_for_testing_->Unserialize(detail.update)) 1961 CHECK(ax_tree_for_testing_->Unserialize(detail.update));
1963 << ax_tree_for_testing_->error();
1964 } 1962 }
1965 accessibility_testing_callback_.Run(this, detail.event_type, detail.id); 1963 accessibility_testing_callback_.Run(this, detail.event_type, detail.id);
1966 } 1964 }
1967 } 1965 }
1968 } 1966 }
1969 1967
1970 // Always send an ACK or the renderer can be in a bad state. 1968 // Always send an ACK or the renderer can be in a bad state.
1971 Send(new AccessibilityMsg_Events_ACK(routing_id_, ack_token)); 1969 Send(new AccessibilityMsg_Events_ACK(routing_id_, ack_token));
1972 } 1970 }
1973 1971
(...skipping 1354 matching lines...) Expand 10 before | Expand all | Expand 10 after
3328 // pending_nav_entry_id. If the previous handle was a prematurely aborted 3326 // pending_nav_entry_id. If the previous handle was a prematurely aborted
3329 // navigation loaded via LoadDataWithBaseURL, propagate the entry id. 3327 // navigation loaded via LoadDataWithBaseURL, propagate the entry id.
3330 return NavigationHandleImpl::Create( 3328 return NavigationHandleImpl::Create(
3331 params.url, frame_tree_node_, is_renderer_initiated, 3329 params.url, frame_tree_node_, is_renderer_initiated,
3332 params.was_within_same_page, base::TimeTicks::Now(), 3330 params.was_within_same_page, base::TimeTicks::Now(),
3333 entry_id_for_data_nav, params.gesture, 3331 entry_id_for_data_nav, params.gesture,
3334 false); // started_from_context_menu 3332 false); // started_from_context_menu
3335 } 3333 }
3336 3334
3337 } // namespace content 3335 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698