Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Side by Side Diff: chrome/renderer/extensions/webstore_bindings.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/extensions/webstore_bindings.h" 5 #include "chrome/renderer/extensions/webstore_bindings.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/strings/string_util.h" 10 #include "base/strings/string_util.h"
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 } 187 }
188 188
189 bool WebstoreBindings::OnMessageReceived(const IPC::Message& message) { 189 bool WebstoreBindings::OnMessageReceived(const IPC::Message& message) {
190 IPC_BEGIN_MESSAGE_MAP(WebstoreBindings, message) 190 IPC_BEGIN_MESSAGE_MAP(WebstoreBindings, message)
191 IPC_MESSAGE_HANDLER(ExtensionMsg_InlineWebstoreInstallResponse, 191 IPC_MESSAGE_HANDLER(ExtensionMsg_InlineWebstoreInstallResponse,
192 OnInlineWebstoreInstallResponse) 192 OnInlineWebstoreInstallResponse)
193 IPC_MESSAGE_HANDLER(ExtensionMsg_InlineInstallStageChanged, 193 IPC_MESSAGE_HANDLER(ExtensionMsg_InlineInstallStageChanged,
194 OnInlineInstallStageChanged) 194 OnInlineInstallStageChanged)
195 IPC_MESSAGE_HANDLER(ExtensionMsg_InlineInstallDownloadProgress, 195 IPC_MESSAGE_HANDLER(ExtensionMsg_InlineInstallDownloadProgress,
196 OnInlineInstallDownloadProgress) 196 OnInlineInstallDownloadProgress)
197 IPC_MESSAGE_UNHANDLED(CHECK(false) << "Unhandled IPC message") 197 IPC_MESSAGE_UNHANDLED(CHECK(false))
198 IPC_END_MESSAGE_MAP() 198 IPC_END_MESSAGE_MAP()
199 return true; 199 return true;
200 } 200 }
201 201
202 void WebstoreBindings::OnInlineWebstoreInstallResponse( 202 void WebstoreBindings::OnInlineWebstoreInstallResponse(
203 int install_id, 203 int install_id,
204 bool success, 204 bool success,
205 const std::string& error, 205 const std::string& error,
206 webstore_install::Result result) { 206 webstore_install::Result result) {
207 v8::Isolate* isolate = context()->isolate(); 207 v8::Isolate* isolate = context()->isolate();
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 v8::Isolate* isolate = context()->isolate(); 243 v8::Isolate* isolate = context()->isolate();
244 v8::HandleScope handle_scope(isolate); 244 v8::HandleScope handle_scope(isolate);
245 v8::Context::Scope context_scope(context()->v8_context()); 245 v8::Context::Scope context_scope(context()->v8_context());
246 v8::Local<v8::Value> argv[] = { 246 v8::Local<v8::Value> argv[] = {
247 v8::Number::New(isolate, percent_downloaded / 100.0)}; 247 v8::Number::New(isolate, percent_downloaded / 100.0)};
248 context()->module_system()->CallModuleMethodSafe( 248 context()->module_system()->CallModuleMethodSafe(
249 "webstore", "onDownloadProgress", arraysize(argv), argv); 249 "webstore", "onDownloadProgress", arraysize(argv), argv);
250 } 250 }
251 251
252 } // namespace extensions 252 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698