Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Side by Side Diff: chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/browser_action_test_util.h" 5 #include "chrome/browser/extensions/browser_action_test_util.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/mac/bundle_locations.h" 9 #include "base/mac/bundle_locations.h"
10 #include "base/mac/foundation_util.h" 10 #include "base/mac/foundation_util.h"
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 frame.size.width = width; 184 frame.size.width = width;
185 [containerView setFrame:frame]; 185 [containerView setFrame:frame];
186 } 186 }
187 187
188 ToolbarActionsBar* BrowserActionTestUtil::GetToolbarActionsBar() { 188 ToolbarActionsBar* BrowserActionTestUtil::GetToolbarActionsBar() {
189 return [GetController(browser_, test_helper_.get()) toolbarActionsBar]; 189 return [GetController(browser_, test_helper_.get()) toolbarActionsBar];
190 } 190 }
191 191
192 std::unique_ptr<BrowserActionTestUtil> 192 std::unique_ptr<BrowserActionTestUtil>
193 BrowserActionTestUtil::CreateOverflowBar() { 193 BrowserActionTestUtil::CreateOverflowBar() {
194 CHECK(!GetToolbarActionsBar()->in_overflow_mode()) 194 // Only a main bar can create an overflow bar!
195 << "Only a main bar can create an overflow bar!"; 195 CHECK(!GetToolbarActionsBar()->in_overflow_mode());
196 return base::WrapUnique(new BrowserActionTestUtil(browser_, this)); 196 return base::WrapUnique(new BrowserActionTestUtil(browser_, this));
197 } 197 }
198 198
199 // static 199 // static
200 gfx::Size BrowserActionTestUtil::GetMinPopupSize() { 200 gfx::Size BrowserActionTestUtil::GetMinPopupSize() {
201 return gfx::Size(NSSizeToCGSize([ExtensionPopupController minPopupSize])); 201 return gfx::Size(NSSizeToCGSize([ExtensionPopupController minPopupSize]));
202 } 202 }
203 203
204 // static 204 // static
205 gfx::Size BrowserActionTestUtil::GetMaxPopupSize() { 205 gfx::Size BrowserActionTestUtil::GetMaxPopupSize() {
206 return gfx::Size(NSSizeToCGSize([ExtensionPopupController maxPopupSize])); 206 return gfx::Size(NSSizeToCGSize([ExtensionPopupController maxPopupSize]));
207 } 207 }
208 208
209 BrowserActionTestUtil::BrowserActionTestUtil(Browser* browser, 209 BrowserActionTestUtil::BrowserActionTestUtil(Browser* browser,
210 BrowserActionTestUtil* main_bar) 210 BrowserActionTestUtil* main_bar)
211 : browser_(browser), 211 : browser_(browser),
212 test_helper_(new TestToolbarActionsBarHelperCocoa( 212 test_helper_(new TestToolbarActionsBarHelperCocoa(
213 browser_, GetController(browser_, main_bar->test_helper_.get()))) { 213 browser_, GetController(browser_, main_bar->test_helper_.get()))) {
214 } 214 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698