Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Side by Side Diff: chrome/browser/media/webrtc/webrtc_browsertest_common.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/media/webrtc/webrtc_browsertest_common.h" 5 #include "chrome/browser/media/webrtc/webrtc_browsertest_common.h"
6 6
7 #include "base/files/file_util.h" 7 #include "base/files/file_util.h"
8 #include "base/path_service.h" 8 #include "base/path_service.h"
9 #include "base/strings/string_util.h" 9 #include "base/strings/string_util.h"
10 #include "base/strings/stringprintf.h" 10 #include "base/strings/stringprintf.h"
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 #if defined(OS_WIN) 61 #if defined(OS_WIN)
62 return tools_dir 62 return tools_dir
63 .Append(FILE_PATH_LITERAL("win")) 63 .Append(FILE_PATH_LITERAL("win"))
64 .AppendASCII(tool_name) 64 .AppendASCII(tool_name)
65 .AddExtension(FILE_PATH_LITERAL("exe")); 65 .AddExtension(FILE_PATH_LITERAL("exe"));
66 #elif defined(OS_MACOSX) 66 #elif defined(OS_MACOSX)
67 return tools_dir.Append(FILE_PATH_LITERAL("mac")).AppendASCII(tool_name); 67 return tools_dir.Append(FILE_PATH_LITERAL("mac")).AppendASCII(tool_name);
68 #elif defined(OS_LINUX) 68 #elif defined(OS_LINUX)
69 return tools_dir.Append(FILE_PATH_LITERAL("linux")).AppendASCII(tool_name); 69 return tools_dir.Append(FILE_PATH_LITERAL("linux")).AppendASCII(tool_name);
70 #else 70 #else
71 CHECK(false) << "Can't retrieve tool " << tool_name << " on this platform."; 71 // Can't retrieve tool |tool_name| on this platform.
72 CHECK(false);
72 return base::FilePath(); 73 return base::FilePath();
73 #endif 74 #endif
74 } 75 }
75 76
76 bool HasReferenceFilesInCheckout() { 77 bool HasReferenceFilesInCheckout() {
77 if (!base::PathExists(GetReferenceFilesDir())) { 78 if (!base::PathExists(GetReferenceFilesDir())) {
78 LOG(ERROR) 79 LOG(ERROR)
79 << "Cannot find the working directory for the reference video " 80 << "Cannot find the working directory for the reference video "
80 << "files, expected at " << GetReferenceFilesDir().value() << ". " << 81 << "files, expected at " << GetReferenceFilesDir().value() << ". " <<
81 kAdviseOnGclientSolution; 82 kAdviseOnGclientSolution;
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 } 159 }
159 } 160 }
160 LOG(ERROR) 161 LOG(ERROR)
161 << "Timed out while waiting for " << javascript 162 << "Timed out while waiting for " << javascript
162 << " to evaluate to " << evaluates_to << "; last result was '" << result 163 << " to evaluate to " << evaluates_to << "; last result was '" << result
163 << "'"; 164 << "'";
164 return false; 165 return false;
165 } 166 }
166 167
167 } // namespace test 168 } // namespace test
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698