Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Side by Side Diff: chrome/browser/extensions/standard_management_policy_provider_unittest.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/standard_management_policy_provider.h" 5 #include "chrome/browser/extensions/standard_management_policy_provider.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/message_loop/message_loop.h" 9 #include "base/message_loop/message_loop.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 23 matching lines...) Expand all
34 } 34 }
35 35
36 scoped_refptr<const Extension> CreateExtension(Manifest::Location location, 36 scoped_refptr<const Extension> CreateExtension(Manifest::Location location,
37 bool required) { 37 bool required) {
38 base::DictionaryValue values; 38 base::DictionaryValue values;
39 values.SetString(manifest_keys::kName, "test"); 39 values.SetString(manifest_keys::kName, "test");
40 values.SetString(manifest_keys::kVersion, "0.1"); 40 values.SetString(manifest_keys::kVersion, "0.1");
41 std::string error; 41 std::string error;
42 scoped_refptr<const Extension> extension = Extension::Create( 42 scoped_refptr<const Extension> extension = Extension::Create(
43 base::FilePath(), location, values, Extension::NO_FLAGS, &error); 43 base::FilePath(), location, values, Extension::NO_FLAGS, &error);
44 CHECK(extension.get()) << error; 44 CHECK(extension.get());
45 return extension; 45 return extension;
46 } 46 }
47 47
48 base::MessageLoop message_loop_; 48 base::MessageLoop message_loop_;
49 content::TestBrowserThread ui_thread_; 49 content::TestBrowserThread ui_thread_;
50 content::TestBrowserThread file_thread_; 50 content::TestBrowserThread file_thread_;
51 51
52 TestExtensionPrefs prefs_; 52 TestExtensionPrefs prefs_;
53 std::unique_ptr<ExtensionManagement> settings_; 53 std::unique_ptr<ExtensionManagement> settings_;
54 54
(...skipping 27 matching lines...) Expand all
82 base::string16 error16; 82 base::string16 error16;
83 EXPECT_TRUE(provider_.UserMayLoad(extension.get(), &error16)); 83 EXPECT_TRUE(provider_.UserMayLoad(extension.get(), &error16));
84 EXPECT_EQ(base::string16(), error16); 84 EXPECT_EQ(base::string16(), error16);
85 EXPECT_TRUE(provider_.UserMayModifySettings(extension.get(), &error16)); 85 EXPECT_TRUE(provider_.UserMayModifySettings(extension.get(), &error16));
86 EXPECT_EQ(base::string16(), error16); 86 EXPECT_EQ(base::string16(), error16);
87 EXPECT_FALSE(provider_.MustRemainEnabled(extension.get(), &error16)); 87 EXPECT_FALSE(provider_.MustRemainEnabled(extension.get(), &error16));
88 EXPECT_EQ(base::string16(), error16); 88 EXPECT_EQ(base::string16(), error16);
89 } 89 }
90 90
91 } // namespace extensions 91 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698