Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: chrome/browser/extensions/extension_management_unittest.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_management.h" 5 #include "chrome/browser/extensions/extension_management.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 const std::string& id, 204 const std::string& id,
205 const std::string& update_url) { 205 const std::string& update_url) {
206 base::DictionaryValue manifest_dict; 206 base::DictionaryValue manifest_dict;
207 manifest_dict.SetString(manifest_keys::kName, "test"); 207 manifest_dict.SetString(manifest_keys::kName, "test");
208 manifest_dict.SetString(manifest_keys::kVersion, version); 208 manifest_dict.SetString(manifest_keys::kVersion, version);
209 manifest_dict.SetString(manifest_keys::kUpdateURL, update_url); 209 manifest_dict.SetString(manifest_keys::kUpdateURL, update_url);
210 std::string error; 210 std::string error;
211 scoped_refptr<const Extension> extension = 211 scoped_refptr<const Extension> extension =
212 Extension::Create(base::FilePath(), location, manifest_dict, 212 Extension::Create(base::FilePath(), location, manifest_dict,
213 Extension::NO_FLAGS, id, &error); 213 Extension::NO_FLAGS, id, &error);
214 CHECK(extension.get()) << error; 214 CHECK(extension.get());
215 return extension; 215 return extension;
216 } 216 }
217 }; 217 };
218 218
219 class ExtensionAdminPolicyTest : public ExtensionManagementServiceTest { 219 class ExtensionAdminPolicyTest : public ExtensionManagementServiceTest {
220 public: 220 public:
221 ExtensionAdminPolicyTest() {} 221 ExtensionAdminPolicyTest() {}
222 ~ExtensionAdminPolicyTest() override {} 222 ~ExtensionAdminPolicyTest() override {}
223 223
224 void SetUpPolicyProvider() { 224 void SetUpPolicyProvider() {
(...skipping 649 matching lines...) Expand 10 before | Expand all | Expand 10 after
874 EXPECT_FALSE(error.empty()); 874 EXPECT_FALSE(error.empty());
875 875
876 CreateExtension(Manifest::INTERNAL); 876 CreateExtension(Manifest::INTERNAL);
877 error.clear(); 877 error.clear();
878 EXPECT_FALSE(MustRemainEnabled(extension_.get(), NULL)); 878 EXPECT_FALSE(MustRemainEnabled(extension_.get(), NULL));
879 EXPECT_FALSE(MustRemainEnabled(extension_.get(), &error)); 879 EXPECT_FALSE(MustRemainEnabled(extension_.get(), &error));
880 EXPECT_TRUE(error.empty()); 880 EXPECT_TRUE(error.empty());
881 } 881 }
882 882
883 } // namespace extensions 883 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698