Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_garbage_collector_chromeos.h" 5 #include "chrome/browser/extensions/extension_garbage_collector_chromeos.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/files/file_util.h" 10 #include "base/files/file_util.h"
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 scoped_refptr<Extension> CreateExtension(const std::string& id, 121 scoped_refptr<Extension> CreateExtension(const std::string& id,
122 const std::string& version, 122 const std::string& version,
123 const base::FilePath& path) { 123 const base::FilePath& path) {
124 base::DictionaryValue manifest; 124 base::DictionaryValue manifest;
125 manifest.SetString(manifest_keys::kName, "test"); 125 manifest.SetString(manifest_keys::kName, "test");
126 manifest.SetString(manifest_keys::kVersion, version); 126 manifest.SetString(manifest_keys::kVersion, version);
127 127
128 std::string error; 128 std::string error;
129 scoped_refptr<Extension> extension = Extension::Create( 129 scoped_refptr<Extension> extension = Extension::Create(
130 path, Manifest::INTERNAL, manifest, Extension::NO_FLAGS, id, &error); 130 path, Manifest::INTERNAL, manifest, Extension::NO_FLAGS, id, &error);
131 CHECK(extension.get()) << error; 131 CHECK(extension.get());
132 CHECK_EQ(id, extension->id()); 132 CHECK_EQ(id, extension->id());
133 133
134 return extension; 134 return extension;
135 } 135 }
136 136
137 ExtensionPrefs* GetExtensionPrefs() { 137 ExtensionPrefs* GetExtensionPrefs() {
138 return ExtensionPrefs::Get(profile_.get()); 138 return ExtensionPrefs::Get(profile_.get());
139 } 139 }
140 140
141 chromeos::FakeChromeUserManager* GetFakeUserManager() { 141 chromeos::FakeChromeUserManager* GetFakeUserManager() {
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 191
192 const base::DictionaryValue* shared_extensions = testing_local_state_.Get()-> 192 const base::DictionaryValue* shared_extensions = testing_local_state_.Get()->
193 GetDictionary(ExtensionAssetsManagerChromeOS::kSharedExtensions); 193 GetDictionary(ExtensionAssetsManagerChromeOS::kSharedExtensions);
194 ASSERT_TRUE(shared_extensions); 194 ASSERT_TRUE(shared_extensions);
195 195
196 EXPECT_FALSE(shared_extensions->HasKey(kExtensionId1)); 196 EXPECT_FALSE(shared_extensions->HasKey(kExtensionId1));
197 EXPECT_TRUE(shared_extensions->HasKey(kExtensionId2)); 197 EXPECT_TRUE(shared_extensions->HasKey(kExtensionId2));
198 } 198 }
199 199
200 } // namespace extensions 200 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698