Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Side by Side Diff: chrome/browser/chromeos/login/mixin_based_browser_test.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/login/mixin_based_browser_test.h" 5 #include "chrome/browser/chromeos/login/mixin_based_browser_test.h"
6 6
7 namespace chromeos { 7 namespace chromeos {
8 8
9 MixinBasedBrowserTest::MixinBasedBrowserTest() : setup_was_launched_(false) { 9 MixinBasedBrowserTest::MixinBasedBrowserTest() : setup_was_launched_(false) {
10 } 10 }
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 void MixinBasedBrowserTest::TearDownInProcessBrowserTestFixture() { 50 void MixinBasedBrowserTest::TearDownInProcessBrowserTestFixture() {
51 InProcessBrowserTest::TearDownInProcessBrowserTestFixture(); 51 InProcessBrowserTest::TearDownInProcessBrowserTestFixture();
52 for (ScopedVector<Mixin>::reverse_iterator it = mixins_.rbegin(); 52 for (ScopedVector<Mixin>::reverse_iterator it = mixins_.rbegin();
53 it != mixins_.rend(); 53 it != mixins_.rend();
54 ++it) { 54 ++it) {
55 (*it)->TearDownInProcessBrowserTestFixture(); 55 (*it)->TearDownInProcessBrowserTestFixture();
56 } 56 }
57 } 57 }
58 58
59 void MixinBasedBrowserTest::AddMixin(MixinBasedBrowserTest::Mixin* mixin) { 59 void MixinBasedBrowserTest::AddMixin(MixinBasedBrowserTest::Mixin* mixin) {
60 CHECK(!setup_was_launched_) 60 // You are trying to add a mixin after setting up has already started.
61 << "You are trying to add a mixin after setting up has already started."; 61 CHECK(!setup_was_launched_);
62 mixins_.push_back(mixin); 62 mixins_.push_back(mixin);
63 } 63 }
64 64
65 } // namespace chromeos 65 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698