Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Side by Side Diff: base/check_example.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file is meant for analyzing the code generated by the CHECK 5 // This file is meant for analyzing the code generated by the CHECK
6 // macros in a small executable file that's easy to disassemble. 6 // macros in a small executable file that's easy to disassemble.
7 7
8 #include "base/logging.h" 8 #include "base/logging.h"
9 9
10 // An official build shouldn't generate code to print out messages for 10 // An official build shouldn't generate code to print out messages for
11 // the CHECK* macros, nor should it have the strings in the 11 // the CHECK* macros, nor should it have the strings in the
12 // executable. 12 // executable.
13 13
14 void DoCheck(bool b) { 14 void DoCheck(bool b) {
15 CHECK(b) << "DoCheck " << b; 15 // DoCheck |b|
16 CHECK(b);
16 } 17 }
17 18
18 void DoCheckEq(int x, int y) { 19 void DoCheckEq(int x, int y) {
19 CHECK_EQ(x, y); 20 CHECK_EQ(x, y);
20 } 21 }
21 22
22 int main(int argc, const char* argv[]) { 23 int main(int argc, const char* argv[]) {
23 DoCheck(argc > 1); 24 DoCheck(argc > 1);
24 DoCheckEq(argc, 1); 25 DoCheckEq(argc, 1);
25 } 26 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698