Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 256193003: Add dependency on remoting_webapp in browser_tests. (Closed)

Created:
6 years, 7 months ago by Sergey Ulanov
Modified:
6 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, chromoting-reviews_chromium.org
Visibility:
Public.

Description

Add dependency on remoting_webapp in browser_tests. browser_tests containts some tests for remoting, so it depends on remoting_webapp, but didn't have the dependency defined in gyp. Also added exclusion for remoting browser tests when remoting=0. R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266921

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/chrome_tests.gypi View 1 chunk +9 lines, -0 lines 2 comments Download

Messages

Total messages: 9 (0 generated)
Sergey Ulanov
6 years, 7 months ago (2014-04-28 20:54:57 UTC) #1
Nico
https://codereview.chromium.org/256193003/diff/1/chrome/chrome_tests.gypi File chrome/chrome_tests.gypi (right): https://codereview.chromium.org/256193003/diff/1/chrome/chrome_tests.gypi#newcode1965 chrome/chrome_tests.gypi:1965: ['exclude', '^test/remoting'], Why do you need this?
6 years, 7 months ago (2014-04-28 21:47:52 UTC) #2
Sergey Ulanov
https://codereview.chromium.org/256193003/diff/1/chrome/chrome_tests.gypi File chrome/chrome_tests.gypi (right): https://codereview.chromium.org/256193003/diff/1/chrome/chrome_tests.gypi#newcode1965 chrome/chrome_tests.gypi:1965: ['exclude', '^test/remoting'], On 2014/04/28 21:47:52, Nico wrote: > Why ...
6 years, 7 months ago (2014-04-28 23:32:47 UTC) #3
Nico
lgtm
6 years, 7 months ago (2014-04-28 23:54:22 UTC) #4
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 7 months ago (2014-04-28 23:59:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/256193003/1
6 years, 7 months ago (2014-04-29 00:01:21 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 00:07:35 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_gn_rel
6 years, 7 months ago (2014-04-29 00:07:35 UTC) #8
Sergey Ulanov
6 years, 7 months ago (2014-04-29 18:08:35 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 manually as r266921 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698