Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: net/tools/quic/test_tools/quic_test_server.cc

Issue 2561913003: Create a QUIC wrapper around a mutex and a mutex lock. (Closed)
Patch Set: fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/test_tools/packet_dropping_test_writer.cc ('k') | net/tools/quic/test_tools/server_thread.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/test_tools/quic_test_server.cc
diff --git a/net/tools/quic/test_tools/quic_test_server.cc b/net/tools/quic/test_tools/quic_test_server.cc
index e5375fffee7cecdede52b70777fc028b0d966030..9d987b31e30d49b09f36ea9489758c8353e26f1c 100644
--- a/net/tools/quic/test_tools/quic_test_server.cc
+++ b/net/tools/quic/test_tools/quic_test_server.cc
@@ -102,7 +102,7 @@ class QuicTestDispatcher : public QuicSimpleDispatcher {
QuicServerSessionBase* CreateQuicSession(
QuicConnectionId id,
const QuicSocketAddress& client) override {
- base::AutoLock lock(factory_lock_);
+ QuicReaderMutexLock lock(&factory_lock_);
if (session_factory_ == nullptr && stream_factory_ == nullptr &&
crypto_stream_factory_ == nullptr) {
return QuicSimpleDispatcher::CreateQuicSession(id, client);
@@ -128,7 +128,7 @@ class QuicTestDispatcher : public QuicSimpleDispatcher {
}
void SetSessionFactory(QuicTestServer::SessionFactory* factory) {
- base::AutoLock lock(factory_lock_);
+ QuicWriterMutexLock lock(&factory_lock_);
DCHECK(session_factory_ == nullptr);
DCHECK(stream_factory_ == nullptr);
DCHECK(crypto_stream_factory_ == nullptr);
@@ -136,21 +136,21 @@ class QuicTestDispatcher : public QuicSimpleDispatcher {
}
void SetStreamFactory(QuicTestServer::StreamFactory* factory) {
- base::AutoLock lock(factory_lock_);
+ QuicWriterMutexLock lock(&factory_lock_);
DCHECK(session_factory_ == nullptr);
DCHECK(stream_factory_ == nullptr);
stream_factory_ = factory;
}
void SetCryptoStreamFactory(QuicTestServer::CryptoStreamFactory* factory) {
- base::AutoLock lock(factory_lock_);
+ QuicWriterMutexLock lock(&factory_lock_);
DCHECK(session_factory_ == nullptr);
DCHECK(crypto_stream_factory_ == nullptr);
crypto_stream_factory_ = factory;
}
private:
- base::Lock factory_lock_;
+ QuicMutex factory_lock_;
QuicTestServer::SessionFactory* session_factory_; // Not owned.
QuicTestServer::StreamFactory* stream_factory_; // Not owned.
QuicTestServer::CryptoStreamFactory* crypto_stream_factory_; // Not owned.
« no previous file with comments | « net/tools/quic/test_tools/packet_dropping_test_writer.cc ('k') | net/tools/quic/test_tools/server_thread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698