Add QUIC_EXPORT macros

net/quic/core/congestion_control/bandwidth_sampler.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_QUIC_CORE_CONGESTION_CONTROL_BANDWIDTH_SAMPLER_H_
 #define NET_QUIC_CORE_CONGESTION_CONTROL_BANDWIDTH_SAMPLER_H_
 
 #include "net/base/linked_hash_map.h"
 #include "net/quic/core/quic_bandwidth.h"
 #include "net/quic/core/quic_packets.h"
 #include "net/quic/core/quic_time.h"
+#include "net/quic/platform/api/quic_export.h"

[Zhongyi Shi, 2016/12/08 23:19:31]

I actually didn't see this file present in this CL? Could you add that file?

[Ryan Hamilton, 2016/12/09 00:40:41]

*scratch head* I don't understand how that happened? I clearly did something
wrong with git.

It's there now.

 
 namespace net {
 
 namespace test {
 class BandwidthSamplerPeer;
 }  // namespace test
 
-struct NET_EXPORT_PRIVATE BandwidthSample {
+struct QUIC_EXPORT_PRIVATE BandwidthSample {
   // The bandwidth at that particular sample. Zero if no valid bandwidth sample
   // is available.
   QuicBandwidth bandwidth;
 
   // The RTT measurement at this particular sample.  Zero if no RTT sample is
   // available.  Does not correct for delayed ack time.
   QuicTime::Delta rtt;
 
   // Indicates whether the sample might be artificially low because the sender
   // did not have enough data to send in order to saturate the link.
@@ skipping 78 matching lines @@
 // we use to compute the slope is going to be packet 20, a few seconds apart
 // from the current packet, hence the resulting estimate would be extremely low
 // and not indicative of anything. Only at packet 41 the S_0/A_0 will become 21,
 // meaning that the bandwidth sample would exclude the quiescence.
 //
 // Based on the analysis of that scenario, we implement the following rule: once
 // OnAppLimited() is called, all sent packets will produce app-limited samples
 // up until an ack for a packet that was sent after OnAppLimited() was called.
 // Note that while the scenario above is not the only scenario when the
 // connection is app-limited, the approach works in other cases too.
-class NET_EXPORT_PRIVATE BandwidthSampler {
+class QUIC_EXPORT_PRIVATE BandwidthSampler {
  public:
   BandwidthSampler();
   ~BandwidthSampler();
 
   // Inputs the sent packet information into the sampler. Assumes that all
   // packets are sent in order. The information about the packet will not be
   // released from the sampler until it the packet is either acknowledged or
   // declared lost.
   void OnPacketSent(QuicTime sent_time,
                     QuicPacketNumber packet_number,
@@ skipping 107 matching lines @@
   QuicPacketNumber end_of_app_limited_phase_;
 
   // Record of the connection state at the point where each packet in flight was
   // sent, indexed by the packet number.
   ConnectionStateMap connection_state_map_;
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_CORE_CONGESTION_CONTROL_BANDWIDTH_SAMPLER_H_