Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2561863003: Add test for MemoryCoordinatorImpl::ForceSetGlobalState() (Closed)

Created:
4 years ago by bashi
Modified:
4 years ago
Reviewers:
haraken, chrisha
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add test for MemoryCoordinatorImpl::ForceSetGlobalState() This is a follow-up CL of crrev.com/2550183007. BUG=617492 Committed: https://crrev.com/c2baca69986fcd55ada1be0c952b5737dc71c648 Cr-Commit-Position: refs/heads/master@{#437443}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -1 line) Patch
M content/browser/memory/memory_coordinator_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/memory/memory_coordinator_impl_unittest.cc View 4 chunks +49 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
bashi
PTAL. I thought I should write tests more often :)
4 years ago (2016-12-09 00:52:05 UTC) #4
haraken
LGTM
4 years ago (2016-12-09 01:05:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2561863003/1
4 years ago (2016-12-09 02:27:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 02:38:46 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-09 02:41:34 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2baca69986fcd55ada1be0c952b5737dc71c648
Cr-Commit-Position: refs/heads/master@{#437443}

Powered by Google App Engine
This is Rietveld 408576698