Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2561843002: dart2js-kernel: associate more compound assignment inner nodes (Closed)

Created:
4 years ago by sra1
Modified:
4 years ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org, asgerf
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js-kernel: associate more compound assignment inner nodes We can now find the inner nodes (reads and binary operations) of a[i]++, ++a[i], a[i]*=9. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/71a344438d5f4348b29382f0724d48d1012e646b

Patch Set 1 #

Patch Set 2 : remove comment #

Patch Set 3 : move voidContext deeper #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -36 lines) Patch
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 1 2 6 chunks +52 lines, -29 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/kernel/lib/frontend/accessors.dart View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
4 years ago (2016-12-08 19:22:24 UTC) #2
Emily Fortuna
lgtm
4 years ago (2016-12-08 19:33:04 UTC) #3
sra1
4 years ago (2016-12-08 19:47:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
71a344438d5f4348b29382f0724d48d1012e646b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698