Cronet smoke tests

components/cronet/android/test/smoketests/src/org/chromium/net/smoke/H2Test.java

Index: components/cronet/android/test/smoketests/src/org/chromium/net/smoke/H2Test.java
diff --git a/components/cronet/android/test/smoketests/src/org/chromium/net/smoke/H2Test.java b/components/cronet/android/test/smoketests/src/org/chromium/net/smoke/H2Test.java
new file mode 100644
index 0000000000000000000000000000000000000000..7b0bff9cd8ec1909357eaedbfb947b69872de618
--- /dev/null
+++ b/components/cronet/android/test/smoketests/src/org/chromium/net/smoke/H2Test.java
@@ -0,0 +1,36 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.net.smoke;
+
+import android.annotation.TargetApi;
+import android.test.suitebuilder.annotation.Smoke;
+
+import static org.chromium.net.smoke.TestSupport.Protocol.H2;
+
+import org.chromium.net.UrlRequest;
+
+/**
+ * H2 Tests.
+ */
+@TargetApi(19)

[mef, 2016/12/08 23:17:18]

Could you add comment as to why @TargetApi(19) is needed?

[kapishnikov, 2016/12/19 19:31:10]

It was needed for the 'try' block that auto-closes the test server. Added
setUp() and tearDown() methods instead here and in QuicTest.

+public class H2Test extends NativeCronetTestBase {
+    // Test that HTTP/2 is enabled by default but QUIC is not.
+    @Smoke
+    public void testHttp2() throws Exception {
+        mTestSupport.installMockCertVerifierForTesting(mCronetEngineBuilder);
+        initCronetEngine();
+        try (TestSupport.TestServer server = mTestSupport.createTestServer(getContext(), H2)) {

[mef, 2016/12/08 23:17:18]

Can it be TestSupport.Protocol.H2 here?

[kapishnikov, 2016/12/19 19:31:10]

Done.

+            assertTrue(server.start());
+            TestUrlRequestCallback callback = new TestUrlRequestCallback();
+            UrlRequest.Builder requestBuilder = mCronetEngine.newUrlRequestBuilder(
+                    server.getSuccessURL(), callback, callback.getExecutor());
+            requestBuilder.build().start();
+            callback.blockForDone();
+
+            assertSuccessfulNonEmptyResponse(callback.mResponseInfo, server.getSuccessURL());
+            assertEquals("h2", callback.mResponseInfo.getNegotiatedProtocol());
+        }
+    }
+}