Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.h

Issue 2561773003: Parse input argument types and store the argument types in CSSPaintDefinition. (Closed)
Patch Set: update tests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.h
diff --git a/third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.h b/third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.h
index 2b7ccfbc5ef4d790781df92da4b1fc4da010c723..47590a6c9049ffb3ca42701b876452c95b8bd1bc 100644
--- a/third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.h
+++ b/third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.h
@@ -7,6 +7,7 @@
#include "bindings/core/v8/ScopedPersistent.h"
#include "core/CSSPropertyNames.h"
+#include "core/css/CSSSyntaxDescriptor.h"
#include "platform/geometry/IntSize.h"
#include "platform/heap/Handle.h"
#include <v8.h>
@@ -18,7 +19,8 @@ class LayoutObject;
class ScriptState;
// Represents a javascript class registered on the PaintWorkletGlobalScope by
-// the author.
+// the author. It will store the properties for invalidation and input argument
+// types as well.
class CSSPaintDefinition final
: public GarbageCollectedFinalized<CSSPaintDefinition> {
public:
@@ -28,6 +30,7 @@ class CSSPaintDefinition final
v8::Local<v8::Function> paint,
Vector<CSSPropertyID>&,
Vector<AtomicString>& customInvalidationProperties,
+ Vector<CSSSyntaxDescriptor>& inputArgumentTypes,
bool hasAlpha);
virtual ~CSSPaintDefinition();
@@ -44,6 +47,9 @@ class CSSPaintDefinition final
const Vector<AtomicString>& customInvalidationProperties() const {
return m_customInvalidationProperties;
}
+ const Vector<CSSSyntaxDescriptor>& inputArgumentTypes() const {
+ return m_inputArgumentTypes;
+ }
bool hasAlpha() const { return m_hasAlpha; }
ScriptState* getScriptState() const { return m_scriptState.get(); }
@@ -60,6 +66,7 @@ class CSSPaintDefinition final
v8::Local<v8::Function> paint,
Vector<CSSPropertyID>& nativeInvalidationProperties,
Vector<AtomicString>& customInvalidationProperties,
+ Vector<CSSSyntaxDescriptor>& inputArgumentTypes,
bool hasAlpha);
void maybeCreatePaintInstance();
@@ -79,6 +86,8 @@ class CSSPaintDefinition final
Vector<CSSPropertyID> m_nativeInvalidationProperties;
Vector<AtomicString> m_customInvalidationProperties;
+ // Input argument types, if applicable.
+ Vector<CSSSyntaxDescriptor> m_inputArgumentTypes;
bool m_hasAlpha;
};

Powered by Google App Engine
This is Rietveld 408576698