Parse input argument types and store the argument types in CSSPaintDefinition.

third_party/WebKit/Source/modules/csspaint/PaintWorkletTest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/csspaint/PaintWorklet.h"
 
 #include "bindings/core/v8/ScriptSourceCode.h"
 #include "bindings/core/v8/V8GCController.h"
 #include "bindings/core/v8/WorkerOrWorkletScriptController.h"
+#include "core/css/CSSSyntaxDescriptor.h"
 #include "core/frame/LocalFrame.h"
 #include "core/testing/DummyPageHolder.h"
 #include "modules/csspaint/CSSPaintDefinition.h"
 #include "modules/csspaint/PaintWorkletGlobalScope.h"
 #include "modules/csspaint/WindowPaintWorklet.h"
+#include "testing/gmock/include/gmock/gmock.h"

[ikilpatrick, 2017/01/13 18:50:18]

oh, just use EXPECT_EQ in gtest.h and remove this depedency since we aren't
mocking anything.

[renjieliu1, 2017/01/15 05:05:20]

Done.

 #include "testing/gtest/include/gtest/gtest.h"
 #include <memory>
 
 namespace blink {
 
 class PaintWorkletTest : public testing::Test {
  public:
   PaintWorkletTest() : m_page(DummyPageHolder::create()) {}
 
   PaintWorklet* paintWorklet() {
@@ skipping 35 matching lines @@
 
   // Delete the page & associated objects.
   m_page.reset();
 
   // Run a GC, the persistent should have been collected.
   ThreadState::current()->collectAllGarbage();
   V8GCController::collectAllGarbageForTesting(isolate);
   ASSERT(handle.isEmpty());
 }
 
-}  // naespace blink
+TEST_F(PaintWorkletTest, CSSPaintInputArgumentsParsing) {
+  PaintWorkletGlobalScope* globalScope =
+      paintWorklet()->workletGlobalScopeProxy();
+  globalScope->scriptController()->evaluate(ScriptSourceCode(
+      "registerPaint('arguments', class {"
+      "static get inputArguments(){return ['<length>'];} paint() { } });"));
+
+  CSSPaintDefinition* definition = globalScope->findDefinition("arguments");
+  DCHECK(definition);
+  EXPECT_THAT(definition->inputArgumentTypes().size(), 1);

[ikilpatrick, 2017/01/13 18:50:18]

So these tests doesn't add that much, it would be better if it also checked the
parsed inputArgumentTypes where of the correct type.

If not, i would delete.

[renjieliu1, 2017/01/15 05:05:20]

CSSSyntaxDescriptor hasn't implemented a compare method, so it's hard to check
the type for now. I will delete the two tests.

+}
+
+TEST_F(PaintWorkletTest, CSSPaintInputArgumentsNoArguments) {
+  PaintWorkletGlobalScope* globalScope =
+      paintWorklet()->workletGlobalScopeProxy();
+  globalScope->scriptController()->evaluate(
+      ScriptSourceCode("registerPaint('noArguments', class { paint() { } });"));
+
+  CSSPaintDefinition* definition = globalScope->findDefinition("noArguments");
+  DCHECK(definition);
+  EXPECT_THAT(definition->inputArgumentTypes().size(), 0);
+}
+
+}  // namespace blink