Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 2561733002: Add WebGLContextObject::traceWrappers, and trace its context. (Closed)

Created:
4 years ago by Ken Russell (switch to Gerrit)
Modified:
4 years ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add WebGLContextObject::traceWrappers, and trace its context. It's not clear to me whether this could be the cause of Issue 671791, but I can't find any other errors via code inspection. BUG=671791 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true Committed: https://crrev.com/069f876903bc008aae66345a1e5d6686ff7a05b7 Cr-Commit-Position: refs/heads/master@{#437208}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGLContextObject.h View 3 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLContextObject.cpp View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 24 (11 generated)
Ken Russell (switch to Gerrit)
PTAL haraken, mlippautz: I'll have Mo review this and send it through the CQ after. ...
4 years ago (2016-12-08 01:16:41 UTC) #3
haraken
LGTM However, I'm getting confused about the lifetime relationship of these WebGL objects. For example, ...
4 years ago (2016-12-08 01:21:30 UTC) #4
Zhenyao Mo
On 2016/12/08 01:16:41, Ken Russell wrote: > PTAL > > haraken, mlippautz: I'll have Mo ...
4 years ago (2016-12-08 01:32:27 UTC) #5
Ken Russell (switch to Gerrit)
haraken: I'll reply to your question on https://codereview.chromium.org/2560473005/ and also put more comments on http://crbug.com/671791 ...
4 years ago (2016-12-08 01:35:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2561733002/1
4 years ago (2016-12-08 01:35:35 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/352160)
4 years ago (2016-12-08 02:55:18 UTC) #10
Ken Russell (switch to Gerrit)
On 2016/12/08 02:55:18, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years ago (2016-12-08 06:04:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2561733002/1
4 years ago (2016-12-08 06:21:47 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/82060)
4 years ago (2016-12-08 07:45:33 UTC) #15
Ken Russell (switch to Gerrit)
On 2016/12/08 07:45:33, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years ago (2016-12-08 08:01:27 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2561733002/1
4 years ago (2016-12-08 08:01:54 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 08:06:18 UTC) #22
commit-bot: I haz the power
4 years ago (2016-12-08 08:08:58 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/069f876903bc008aae66345a1e5d6686ff7a05b7
Cr-Commit-Position: refs/heads/master@{#437208}

Powered by Google App Engine
This is Rietveld 408576698