|
|
Chromium Code Reviews|
Created:
4 years ago by Ken Russell (switch to Gerrit) Modified:
4 years ago CC:
chromium-reviews, blink-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd WebGLContextObject::traceWrappers, and trace its context.
It's not clear to me whether this could be the cause of Issue 671791,
but I can't find any other errors via code inspection.
BUG=671791
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
NOTRY=true
Committed: https://crrev.com/069f876903bc008aae66345a1e5d6686ff7a05b7
Cr-Commit-Position: refs/heads/master@{#437208}
Patch Set 1 #
Messages
Total messages: 24 (11 generated)
Description was changed from ========== Add WebGLContextObject::traceWrappers, and trace its context. It's not clear to me whether this could be the cause of Issue 671791, but I can't find any other errors via code inspection. BUG=671791 ========== to ========== Add WebGLContextObject::traceWrappers, and trace its context. It's not clear to me whether this could be the cause of Issue 671791, but I can't find any other errors via code inspection. BUG=671791 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
kbr@chromium.org changed reviewers: + haraken@chromium.org, mlippautz@chromium.org, zmo@chromium.org
PTAL haraken, mlippautz: I'll have Mo review this and send it through the CQ after. Appreciate any help continuing to diagnose this.
LGTM However, I'm getting confused about the lifetime relationship of these WebGL objects. For example, see my question in https://codereview.chromium.org/2560473005/#msg7 . I appreciate if you draw a diagram of the object lifetime relationship as a comment.
On 2016/12/08 01:16:41, Ken Russell wrote: > PTAL > > haraken, mlippautz: I'll have Mo review this and send it through the CQ after. > Appreciate any help continuing to diagnose this. lgtm
haraken: I'll reply to your question on https://codereview.chromium.org/2560473005/ and also put more comments on http://crbug.com/671791 .
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
On 2016/12/08 02:55:18, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) Filed http://crbug.com/672367 about this failure.
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
On 2016/12/08 07:45:33, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, > https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...) I filed http://crbug.com/672382 about pervasive android_n5x_swarming_rel flakiness. Since all the other tests passed I'm forcing this through with NOTRY=true.
Description was changed from ========== Add WebGLContextObject::traceWrappers, and trace its context. It's not clear to me whether this could be the cause of Issue 671791, but I can't find any other errors via code inspection. BUG=671791 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add WebGLContextObject::traceWrappers, and trace its context. It's not clear to me whether this could be the cause of Issue 671791, but I can't find any other errors via code inspection. BUG=671791 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true ==========
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481184099693990, "parent_rev":
"b4d3113df2c6a3baba9a5b05444defbc608ede3f", "commit_rev":
"ea4c8d60b62305a61212854a81b732340ea118b0"}
Message was sent while issue was closed.
Description was changed from ========== Add WebGLContextObject::traceWrappers, and trace its context. It's not clear to me whether this could be the cause of Issue 671791, but I can't find any other errors via code inspection. BUG=671791 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true ========== to ========== Add WebGLContextObject::traceWrappers, and trace its context. It's not clear to me whether this could be the cause of Issue 671791, but I can't find any other errors via code inspection. BUG=671791 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add WebGLContextObject::traceWrappers, and trace its context. It's not clear to me whether this could be the cause of Issue 671791, but I can't find any other errors via code inspection. BUG=671791 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true ========== to ========== Add WebGLContextObject::traceWrappers, and trace its context. It's not clear to me whether this could be the cause of Issue 671791, but I can't find any other errors via code inspection. BUG=671791 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true Committed: https://crrev.com/069f876903bc008aae66345a1e5d6686ff7a05b7 Cr-Commit-Position: refs/heads/master@{#437208} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/069f876903bc008aae66345a1e5d6686ff7a05b7 Cr-Commit-Position: refs/heads/master@{#437208} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
