Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/kernel/lib/import_table.dart

Issue 2561723003: Merge kernel closure conversion into the Dart SDK (Closed)
Patch Set: Also restrict the test to linux for now Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/kernel/lib/clone.dart ('k') | pkg/kernel/lib/testing/kernel_chain.dart » ('j') | pkg/kernel/lib/testing/kernel_chain.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/lib/import_table.dart
diff --git a/pkg/kernel/lib/import_table.dart b/pkg/kernel/lib/import_table.dart
index 89c2998256d7015891c7e6167ba8a756b0d14334..3aa59e0805ebc39bfd9084868f6d0dfe70777d85 100644
--- a/pkg/kernel/lib/import_table.dart
+++ b/pkg/kernel/lib/import_table.dart
@@ -88,7 +88,7 @@ class _ImportTableBuilder extends RecursiveVisitor {
path.relative(targetDirectory, from: currentDirectory);
var filename = path.basename(targetUri.path);
table.addImport(target, '$relativeDirectory/$filename');
- } else if (targetUri.scheme == 'file') {
+ } else if (targetUri.scheme == 'file' && referenceUri.path != "_builtin") {
asgerf 2016/12/09 10:57:58 Please add a comment explaining what this is
karlklose 2016/12/15 07:54:19 Removed.
// Cannot import a file:URI from a dart:URI or package:URI.
// We may want to remove this restriction, but for now it's just a sanity
// check.
« no previous file with comments | « pkg/kernel/lib/clone.dart ('k') | pkg/kernel/lib/testing/kernel_chain.dart » ('j') | pkg/kernel/lib/testing/kernel_chain.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698