Merge kernel closure conversion into the Dart SDK

Merge kernel closure conversion into the Dart SDK

This is the result of:
- taking the diff of the branch closure_conversion to master in the kernel
repository
- updating the file paths
- applying the diff to the Dart SDK
- fixing conflicts between the changes to pkg/kernel in the Dart SDK and the master branch in the kernel repository

R=asgerf@google.com

Committed: https://github.com/dart-lang/sdk/commit/ff99a0ce59e31e30f1903e3df76a4fd24990ee48

[karlklose, 2016-12-09 08:01:51]

karlklose@google.com changed reviewers:
+ ahe@google.com, asgerf@google.com

[asgerf, 2016-12-09 10:57:58]

Sorry, I should have mentioned this the other day, but I would really like the
code
to be strong-mode clean and dartfmt'ed first.

The strong-mode requirement is especially important, as the warnings will show
up for
everyone working on kernel, and obscure any new warnings that might show up.

(I realize there is currently a strong-mode warning in mixin resolution, because
the analyzer
was updated after that code landed, that should be fixed too, but of course not
in this CL)

The test inputs should be under the "testcases" folder, where code does not have
to be
strong-mode clean.

And then please run:

    dartanalyzer --strong pkg/kernel/{lib,bin,test}

and fix whatever warnings appear (in the new code).

https://codereview.chromium.org/2561723003/diff/80001/pkg/kernel/lib/import_t...
File pkg/kernel/lib/import_table.dart (right):

https://codereview.chromium.org/2561723003/diff/80001/pkg/kernel/lib/import_t...
pkg/kernel/lib/import_table.dart:91: } else if (targetUri.scheme == 'file' &&
referenceUri.path != "_builtin") {
Please add a comment explaining what this is

https://codereview.chromium.org/2561723003/diff/80001/pkg/kernel/lib/testing/...
File pkg/kernel/lib/testing/kernel_chain.dart (right):

https://codereview.chromium.org/2561723003/diff/80001/pkg/kernel/lib/testing/...
pkg/kernel/lib/testing/kernel_chain.dart:25: import
'package:testing/testing.dart' show
This should not be imported from something under the kernel/lib folder.

Shouldn't this file be under kernel/test somewhere?

https://codereview.chromium.org/2561723003/diff/80001/pkg/kernel/lib/transfor...
File pkg/kernel/lib/transformations/closure/converter.dart (right):

https://codereview.chromium.org/2561723003/diff/80001/pkg/kernel/lib/transfor...
pkg/kernel/lib/transformations/closure/converter.dart:733: implementedTypes:
<Supertype>[new Supertype(coreTypes.functionClass, const <DartType>[])],
Long line.

Could you please dartfmt the whole thing?

[karlklose, 2016-12-15 07:54:19]

PTAL

Please note that I used dartfmt from 1.22.0-dev.1.0, which changed a few files I
had not changed myself. Should we pin a version of dartfmt?

https://codereview.chromium.org/2561723003/diff/80001/pkg/kernel/lib/import_t...
File pkg/kernel/lib/import_table.dart (right):

https://codereview.chromium.org/2561723003/diff/80001/pkg/kernel/lib/import_t...
pkg/kernel/lib/import_table.dart:91: } else if (targetUri.scheme == 'file' &&
referenceUri.path != "_builtin") {
On 2016/12/09 10:57:58, asgerf wrote:
> Please add a comment explaining what this is

Removed.

https://codereview.chromium.org/2561723003/diff/80001/pkg/kernel/lib/testing/...
File pkg/kernel/lib/testing/kernel_chain.dart (right):

https://codereview.chromium.org/2561723003/diff/80001/pkg/kernel/lib/testing/...
pkg/kernel/lib/testing/kernel_chain.dart:25: import
'package:testing/testing.dart' show
On 2016/12/09 10:57:58, asgerf wrote:
> This should not be imported from something under the kernel/lib folder.
> 
> Shouldn't this file be under kernel/test somewhere?

Done.

[asgerf, 2016-12-15 08:56:07]

LGTM

[karlklose, 2016-12-15 09:16:27]

Description was changed from

==========
Merge kernel closure conversion into the Dart SDK

This is the result of:
- taking the diff of the branch closure_conversion to master in the kernel
repository
- updating the file paths
- applying the diff to the Dart SDK
- fixing conflicts between the changes to pkg/kernel in the Dart SDK and the
master branch in the kernel repository
==========

to

==========
Merge kernel closure conversion into the Dart SDK

This is the result of:
- taking the diff of the branch closure_conversion to master in the kernel
repository
- updating the file paths
- applying the diff to the Dart SDK
- fixing conflicts between the changes to pkg/kernel in the Dart SDK and the
master branch in the kernel repository

R=asgerf@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ff99a0ce59e31e30f1903e3df76a4fd24990ee48
==========

[karlklose, 2016-12-15 09:16:28]

Committed patchset #7 (id:120001) manually as
ff99a0ce59e31e30f1903e3df76a4fd24990ee48 (presubmit successful).