third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp - Issue 2561693002: Move sticky position constraints update to the pre-paint tree walk.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

Issue 2561693002: Move sticky position constraints update to the pre-paint tree walk. (Closed)

Patch Set: none Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('j') | third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

index c831a2605904e4ae941b716ace1e67b280e12d7b..24332fe0ebdc39ae3afc7e08dc70fa784b472ba2 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

@@ -102,7 +102,8 @@ void CompositingInputsUpdater::updateRecursive(PaintLayer* layer,

layer->updateAncestorOverflowLayer(info.lastOverflowClipLayer);

if (info.lastOverflowClipLayer && layer->needsCompositingInputsUpdate() &&

layer->layoutObject()->style()->position() == StickyPosition) {

- if (info.lastOverflowClipLayer != previousOverflowLayer) {

+ if (info.lastOverflowClipLayer != previousOverflowLayer &&

+ !RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {

// Old ancestor scroller should no longer have these constraints.

ASSERT(!previousOverflowLayer ||

!previousOverflowLayer->getScrollableArea()