Handle per-tab AUTOMATIC_DOWNLOADS setting in DownloadRequestLimiter.

chrome/browser/download/download_request_limiter_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/download_request_limiter.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/run_loop.h"
 #include "build/build_config.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
-#include "chrome/test/base/testing_profile.h"
 #include "components/content_settings/core/browser/host_content_settings_map.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/navigation_details.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_source.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/frame_navigate_params.h"
 #include "content/public/test/web_contents_tester.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 111 matching lines @@
  private:
   std::unique_ptr<MockPermissionPromptFactory> mock_permission_prompt_factory_;
 };
 #endif
 }  // namespace
 
 class DownloadRequestLimiterTest : public ChromeRenderViewHostTestHarness {
  public:
   void SetUp() override {
     ChromeRenderViewHostTestHarness::SetUp();
-    profile_.reset(new TestingProfile());
     testing_delegate_.SetUp(web_contents());
 
     UpdateExpectations(ACCEPT);
     cancel_count_ = continue_count_ = 0;
     download_request_limiter_ = new DownloadRequestLimiter();
-
-    content_settings_ = new HostContentSettingsMap(
-        profile_->GetPrefs(), false /* incognito_profile */,
-        false /* guest_profile */);
-    DownloadRequestLimiter::SetContentSettingsForTesting(
-        content_settings_.get());
   }
 
   void TearDown() override {

[alshabalin, 2017/03/01 12:18:23]

DownloadRequestLimiter::TabDownloadState now depends on HostContentSettingsMap
by being its observer. But in these tests HostContentSettingsMap was deleted
before TabDownloadState (which will be deleted when associated WebContents is
destroyed).

I decided not to create custom HostContentSettingsMap anymore and just use one
associated with a BrowserContext. This brings object lifetimes in the tests
closer to the real world. 

-    content_settings_->ShutdownOnUIThread();
-    content_settings_ = nullptr;
     testing_delegate_.TearDown();
 
-    // |profile_| must be teared down before
-    // |RenderViewHostTestHarness::thread_bundle_|.
-    profile_.reset();
-
     ChromeRenderViewHostTestHarness::TearDown();
   }
 
   void CanDownload() {
     CanDownloadFor(web_contents());
   }
 
   void CanDownloadFor(WebContents* web_contents) {
     download_request_limiter_->CanDownloadImpl(
         web_contents,
@@ skipping 26 matching lines @@
     EXPECT_EQ(expect_asks, AskAllowCount()) << "line " << line;
     continue_count_ = cancel_count_ = 0;
     testing_delegate_.ResetCounts();
   }
 
   void UpdateContentSettings(WebContents* web_contents,
                              ContentSetting setting) {
     // Ensure a download state exists.
     download_request_limiter_->GetDownloadState(web_contents, nullptr, true);
     SetHostContentSetting(web_contents, setting);
-
-    // Manually send the update notification. In the browser, this is sent from
-    // ContentSettingRPHBubbleModel.
-    content::NotificationService::current()->Notify(
-        chrome::NOTIFICATION_WEB_CONTENT_SETTINGS_CHANGED,
-        content::Source<WebContents>(web_contents),
-        content::NotificationService::NoDetails());
   }
 
  protected:
   void ContinueDownload(bool allow) {
     if (allow) {
       continue_count_++;
     } else {
       cancel_count_++;
     }
   }
 
   void SetHostContentSetting(WebContents* contents, ContentSetting setting) {
-    content_settings_->SetContentSettingDefaultScope(
-        contents->GetURL(), GURL(), CONTENT_SETTINGS_TYPE_AUTOMATIC_DOWNLOADS,
-        std::string(), setting);
+    DownloadRequestLimiter::GetContentSettings(contents)

[dominickn, 2017/03/02 03:32:52]

Instead of exposing GetContentSettings, can you now just call
HostContentSettingsMapFactory::GetForProfile etc. here? Then
DownloadRequestLimiter::GetContentSettings can just be a private method, which
tidies this up a bit more.

[alshabalin, 2017/03/02 09:54:01]

Done. DownloadRequestLimiter::GetContentSettings is already private, however:
DownloadRequestLimiterTest is just a friend of DownloadRequestLimiter.

+        ->SetContentSettingDefaultScope(
+            contents->GetURL(), GURL(),
+            CONTENT_SETTINGS_TYPE_AUTOMATIC_DOWNLOADS, std::string(), setting);
   }
 
   void LoadCompleted() { testing_delegate_.LoadCompleted(web_contents()); }
 
   int AskAllowCount() { return testing_delegate_.AllowCount(); }
 
   void UpdateExpectations(TestingAction action) {
     testing_delegate_.UpdateExpectations(action);
   }
 
   scoped_refptr<DownloadRequestLimiter> download_request_limiter_;
 
   // Number of times ContinueDownload was invoked.
   int continue_count_;
 
   // Number of times CancelDownload was invoked.
   int cancel_count_;
 
-  scoped_refptr<HostContentSettingsMap> content_settings_;
   TestingDelegate testing_delegate_;
-
- private:
-  std::unique_ptr<TestingProfile> profile_;
 };
 
 TEST_F(DownloadRequestLimiterTest, DownloadRequestLimiter_Allow) {
   NavigateAndCommit(GURL("http://foo.com/bar"));
   LoadCompleted();
 
   // All tabs should initially start at ALLOW_ONE_DOWNLOAD.
   ASSERT_EQ(DownloadRequestLimiter::ALLOW_ONE_DOWNLOAD,
             download_request_limiter_->GetDownloadStatus(web_contents()));
 
@@ skipping 373 matching lines @@
   LoadCompleted();
   SetHostContentSetting(web_contents(), CONTENT_SETTING_ALLOW);
 
   CanDownload();
   ExpectAndResetCounts(1, 0, 0, __LINE__);
   ASSERT_EQ(DownloadRequestLimiter::PROMPT_BEFORE_DOWNLOAD,
             download_request_limiter_->GetDownloadStatus(web_contents()));
 
   CanDownload();
   ExpectAndResetCounts(1, 0, 0, __LINE__);
-  ASSERT_EQ(DownloadRequestLimiter::PROMPT_BEFORE_DOWNLOAD,
+  ASSERT_EQ(DownloadRequestLimiter::ALLOW_ALL_DOWNLOADS,
             download_request_limiter_->GetDownloadStatus(web_contents()));
 
   SetHostContentSetting(web_contents(), CONTENT_SETTING_BLOCK);
 
   CanDownload();
   ExpectAndResetCounts(0, 1, 0, __LINE__);
-  ASSERT_EQ(DownloadRequestLimiter::PROMPT_BEFORE_DOWNLOAD,
+  ASSERT_EQ(DownloadRequestLimiter::DOWNLOADS_NOT_ALLOWED,
             download_request_limiter_->GetDownloadStatus(web_contents()));
 
   CanDownload();
   ExpectAndResetCounts(0, 1, 0, __LINE__);
-  ASSERT_EQ(DownloadRequestLimiter::PROMPT_BEFORE_DOWNLOAD,
+  ASSERT_EQ(DownloadRequestLimiter::DOWNLOADS_NOT_ALLOWED,
             download_request_limiter_->GetDownloadStatus(web_contents()));
 }
 
 TEST_F(DownloadRequestLimiterTest,
        DownloadRequestLimiter_ContentSettingChanged) {
   NavigateAndCommit(GURL("http://foo.com/bar"));
   LoadCompleted();
   ASSERT_EQ(DownloadRequestLimiter::ALLOW_ONE_DOWNLOAD,
             download_request_limiter_->GetDownloadStatus(web_contents()));
 
@@ skipping 38 matching lines @@
   // changing the content setting).
   UpdateContentSettings(web_contents(), CONTENT_SETTING_ASK);
   ASSERT_EQ(DownloadRequestLimiter::PROMPT_BEFORE_DOWNLOAD,
             download_request_limiter_->GetDownloadStatus(web_contents()));
   UpdateExpectations(WAIT);
   CanDownload();
   ExpectAndResetCounts(0, 0, 1, __LINE__);
   ASSERT_EQ(DownloadRequestLimiter::PROMPT_BEFORE_DOWNLOAD,
             download_request_limiter_->GetDownloadStatus(web_contents()));
 }