s390: Remove RSubI on s390 and optimize ConstantI

s390: Remove RSubI on s390 and optimize ConstantI

https://github.com/ibmruntimes/v8/issues/27

R=joransiu@ca.ibm.com, bjaideep@ca.ibm.com
BUG=

Committed: https://crrev.com/dcbd3758d9d85e1f955f018bff0d8356315b858a
Cr-Commit-Position: refs/heads/master@{#41591}

[john.yan, 2016-12-07 20:57:57]

ptal

[JoranSiu, 2016-12-07 21:01:42]

https://codereview.chromium.org/2561673002/diff/1/src/crankshaft/s390/lithium...
File src/crankshaft/s390/lithium-s390.cc (right):

https://codereview.chromium.org/2561673002/diff/1/src/crankshaft/s390/lithium...
src/crankshaft/s390/lithium-s390.cc:24: switch (op) {
What is the purpose of this new function?  I don't see how its related to this
CL.

[john.yan, 2016-12-08 02:20:01]

On 2016/12/07 21:01:42, JoranSiu wrote:
>
https://codereview.chromium.org/2561673002/diff/1/src/crankshaft/s390/lithium...
> File src/crankshaft/s390/lithium-s390.cc (right):
> 
>
https://codereview.chromium.org/2561673002/diff/1/src/crankshaft/s390/lithium...
> src/crankshaft/s390/lithium-s390.cc:24: switch (op) {
> What is the purpose of this new function?  I don't see how its related to this
> CL.

updated.

[JoranSiu, 2016-12-08 02:51:37]

lgtm

https://codereview.chromium.org/2561673002/diff/20001/src/s390/macro-assemble...
File src/s390/macro-assembler-s390.cc (right):

https://codereview.chromium.org/2561673002/diff/20001/src/s390/macro-assemble...
src/s390/macro-assembler-s390.cc:4218: lgfi(dst, opnd);
Is this a functional bug that we might need to backport?

[john.yan, 2016-12-08 13:35:07]

On 2016/12/08 02:51:37, JoranSiu wrote:
> lgtm
> 
>
https://codereview.chromium.org/2561673002/diff/20001/src/s390/macro-assemble...
> File src/s390/macro-assembler-s390.cc (right):
> 
>
https://codereview.chromium.org/2561673002/diff/20001/src/s390/macro-assemble...
> src/s390/macro-assembler-s390.cc:4218: lgfi(dst, opnd);
> Is this a functional bug that we might need to backport?

I think it's more of a performance bug. In terms of functional wise, it's
functional correct.

[john.yan, 2016-12-08 13:35:10]

The CQ bit was checked by jyan@ca.ibm.com

[commit-bot: I haz the power, 2016-12-08 13:35:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 14:02:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481204110939470,
"parent_rev": "ab12d2d667cd483db148e36f7e29cdbf2a3bed17", "commit_rev":
"052d4f9b64873ce412cfd54f76a3f6c8ad742f41"}

[commit-bot: I haz the power, 2016-12-08 14:02:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-08 14:03:23]

Description was changed from

==========
s390: Remove RSubI on s390 and optimize ConstantI

https://github.com/ibmruntimes/v8/issues/27

R=joransiu@ca.ibm.com, bjaideep@ca.ibm.com
BUG=
==========

to

==========
s390: Remove RSubI on s390 and optimize ConstantI

https://github.com/ibmruntimes/v8/issues/27

R=joransiu@ca.ibm.com, bjaideep@ca.ibm.com
BUG=

Committed: https://crrev.com/dcbd3758d9d85e1f955f018bff0d8356315b858a
Cr-Commit-Position: refs/heads/master@{#41591}
==========

[commit-bot: I haz the power, 2016-12-08 14:03:24]

Patchset 2 (id:??) landed as
https://crrev.com/dcbd3758d9d85e1f955f018bff0d8356315b858a
Cr-Commit-Position: refs/heads/master@{#41591}