Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2561633005: Change enclosingTextControl to take const Node ptr (Closed)

Created:
4 years ago by Xiaocheng
Modified:
4 years ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change enclosingTextControl to take const Node ptr Function enclosingTextControl(Node*) is not supposed to change anything, and hence, is changed to take a const Node* instead. BUG=n/a Committed: https://crrev.com/b43cc54dad629acd894dc1ab846d0882a4503163 Cr-Commit-Position: refs/heads/master@{#437499}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/html/TextControlElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/TextControlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Xiaocheng
PTAL.
4 years ago (2016-12-09 07:39:36 UTC) #5
tkent
lgtm
4 years ago (2016-12-09 07:42:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2561633005/1
4 years ago (2016-12-09 07:44:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 09:02:49 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-09 09:04:59 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b43cc54dad629acd894dc1ab846d0882a4503163
Cr-Commit-Position: refs/heads/master@{#437499}

Powered by Google App Engine
This is Rietveld 408576698