Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2561633003: Revert of Store OSR'd optimized code on the native context. (Closed)

Created:
4 years ago by Benedikt Meurer
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, Toon Verwaest
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Store OSR'd optimized code on the native context. (patchset #8 id:140001 of https://codereview.chromium.org/2549753002/ ) Reason for revert: Speculative revert WebGL breakage reported in https://bugs.chromium.org/p/chromium/issues/detail?id=672367 Original issue's description: > Store OSR'd optimized code on the native context. > > Since we OSR code rarely, it makes sense to store it and look for it on the native context rather than the SharedFunctionInfo. This makes the OptimizedCodeMap data structure more space efficient, as it doesn't have to store an ast ID for the OSR entry point. > > BUG= > > Committed: https://crrev.com/378b6b22fb7925ac5b672335a54599f5739e7758 > Cr-Commit-Position: refs/heads/master@{#41554} TBR=mstarzinger@chromium.org,ulan@chromium.org,mvstanton@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -273 lines) Patch
M src/bootstrapper.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/builtins/arm/builtins-arm.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/contexts.h View 2 chunks +0 lines, -22 lines 0 comments Download
M src/contexts.cc View 1 chunk +0 lines, -176 lines 0 comments Download
M src/contexts-inl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/debug/debug.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/isolate.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/isolate.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/objects.h View 3 chunks +7 lines, -3 lines 0 comments Download
M src/objects.cc View 6 chunks +46 lines, -34 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallRuntime.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/SuperCallAndSpread.golden View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Benedikt Meurer
Created Revert of Store OSR'd optimized code on the native context.
4 years ago (2016-12-08 06:12:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2561633003/1
4 years ago (2016-12-08 06:12:57 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-08 06:13:51 UTC) #5
Failed to apply patch for
test/cctest/interpreter/bytecode_expectations/CallRuntime.golden:
While running git apply --index -p1;
  error: patch failed:
test/cctest/interpreter/bytecode_expectations/CallRuntime.golden:79
  error: test/cctest/interpreter/bytecode_expectations/CallRuntime.golden: patch
does not apply

Patch:       test/cctest/interpreter/bytecode_expectations/CallRuntime.golden
Index: test/cctest/interpreter/bytecode_expectations/CallRuntime.golden
diff --git a/test/cctest/interpreter/bytecode_expectations/CallRuntime.golden
b/test/cctest/interpreter/bytecode_expectations/CallRuntime.golden
index
b28e9ddd41eb573547d92ecf6e81beb90300e74f..9f672cb8896c805584069a1201172ac0fb454e3c
100644
--- a/test/cctest/interpreter/bytecode_expectations/CallRuntime.golden
+++ b/test/cctest/interpreter/bytecode_expectations/CallRuntime.golden
@@ -79,7 +79,7 @@
                 B(Star), R(0),
                 B(CreateArrayLiteral), U8(0), U8(0), U8(9),
                 B(Star), R(1),
-                B(CallJSRuntime), U8(156), R(0), U8(2),
+                B(CallJSRuntime), U8(155), R(0), U8(2),
   /*   44 S> */ B(Return),
 ]
 constant pool: [

Powered by Google App Engine
This is Rietveld 408576698