Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2561573003: Revert "Move the linter core to the analyzer package" (Closed)

Created:
4 years ago by Paul Berry
Modified:
4 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Move the linter core to the analyzer package" This reverts commit 6d9d5f53a12e5812bb938bfa608b3e40dbe306c6, which was causing analysis server unit tests to fail. TBR=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/1a172e935b555a23a49df728be223895e732f3f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1796 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/linter/linter.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_analysis_options_test.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_errors_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 2 chunks +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/linter/linter_test.dart View 2 chunks +0 lines, -2 lines 0 comments Download
D pkg/analyzer/lib/src/lint/analysis.dart View 1 chunk +0 lines, -262 lines 0 comments Download
D pkg/analyzer/lib/src/lint/config.dart View 1 chunk +0 lines, -243 lines 0 comments Download
D pkg/analyzer/lib/src/lint/io.dart View 1 chunk +0 lines, -68 lines 0 comments Download
D pkg/analyzer/lib/src/lint/linter.dart View 1 chunk +0 lines, -429 lines 0 comments Download
D pkg/analyzer/lib/src/lint/project.dart View 1 chunk +0 lines, -129 lines 0 comments Download
D pkg/analyzer/lib/src/lint/pub.dart View 1 chunk +0 lines, -430 lines 0 comments Download
D pkg/analyzer/lib/src/lint/registry.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D pkg/analyzer/lib/src/lint/util.dart View 1 chunk +0 lines, -172 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Paul Berry
Committed patchset #1 (id:1) manually as 1a172e935b555a23a49df728be223895e732f3f6 (presubmit successful).
4 years ago (2016-12-07 13:36:52 UTC) #2
Brian Wilkerson
4 years ago (2016-12-07 15:02:50 UTC) #3
Message was sent while issue was closed. 
I would have preferred that you had simply disabled the two failing tests.

Powered by Google App Engine
This is Rietveld 408576698