net/third_party/nss/ssl/BUILD.gn - Issue 256153003: GN build improvements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/third_party/nss/ssl/BUILD.gn

Issue 256153003: GN build improvements. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fixewas Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/third_party/nss/ssl/BUILD.gn

diff --git a/net/third_party/nss/ssl/BUILD.gn b/net/third_party/nss/ssl/BUILD.gn

index bcc3668dcaacb263f28144b3db031bb417b56915..ae3d2c38a296d0758d5acd4400165d469ad52dd6 100644

--- a/net/third_party/nss/ssl/BUILD.gn

+++ b/net/third_party/nss/ssl/BUILD.gn

@@ -118,8 +118,8 @@ component("libssl") {

forward_dependent_configs_from = deps

}

- if (component_mode == "shared_library") {

- # TODO(brettw) GCC_SYMBOLS_PRIVATE_EXTERN thing.

+ if (!is_win && component_mode == "shared_library") {

+ configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]

}

if (is_clang) {

« no previous file with comments | « net/BUILD.gn ('k') | third_party/expat/BUILD.gn » ('j') | no next file with comments »