ios/chrome/browser/physical_web/ios_chrome_physical_web_data_source.h - Issue 2561493002: Pass Physical Web metadata through a struct

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/physical_web/ios_chrome_physical_web_data_source.h

Issue 2561493002: Pass Physical Web metadata through a struct (Closed)

Patch Set: Fix missed compile errors Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/physical_web/data_source/physical_web_data_source.h ('K') | « components/physical_web/data_source/physical_web_data_source_impl_unittest.cc ('k') | ios/chrome/browser/ui/webui/physical_web_ui.cc » ('j') | ios/chrome/browser/ui/webui/physical_web_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/physical_web/ios_chrome_physical_web_data_source.h

diff --git a/ios/chrome/browser/physical_web/ios_chrome_physical_web_data_source.h b/ios/chrome/browser/physical_web/ios_chrome_physical_web_data_source.h

index 76385430b8d0c326d1fc517322c1fc76c1d55d09..edded39e706531f32e44e5f9c38177b81f23b309 100644

--- a/ios/chrome/browser/physical_web/ios_chrome_physical_web_data_source.h

+++ b/ios/chrome/browser/physical_web/ios_chrome_physical_web_data_source.h

@@ -31,7 +31,7 @@ class IOSChromePhysicalWebDataSource

// Returns a list of resolved URLs and associated page metadata. If network

// requests are disabled, the list will be empty.

- std::unique_ptr<base::ListValue> GetMetadata() override;

+ std::unique_ptr<base::ListValue> GetMetadataListValue() override;

mattreynolds 2016/12/12 19:41:29 (should be GetMetadata) Also, IOSChromePhysicalWe

// Returns boolean |true| if network requests are disabled and there are one

// or more discovered URLs that have not been sent to the resolution service.