chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java - Issue 2561493002: Pass Physical Web metadata through a struct

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java

Issue 2561493002: Pass Physical Web metadata through a struct (Closed)

Patch Set: Respond to comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/android/physical_web/physical_web_data_source_android.h » ('j') | components/physical_web/data_source/physical_web_data_source.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java

index d5ed9efcc2b7e67e78dbdf21eb93fce6c2df2ab2..41067261a9a656753b7149a3088750b201333095 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java

@@ -294,7 +294,7 @@ class UrlManager {

PwsResult pwsResult = mPwsResultMap.get(requestUrl);

if (pwsResult != null) {

nativeAppendMetadataItem(nativePhysicalWebCollection, requestUrl,

- urlInfo.getDistance(), (int) urlInfo.getScanTimestamp(), pwsResult.siteUrl,

+ urlInfo.getDistance(), urlInfo.getScanTimestamp(), pwsResult.siteUrl,

pwsResult.iconUrl, pwsResult.title, pwsResult.description,

pwsResult.groupId);

}

@@ -830,7 +830,7 @@ class UrlManager {

private native long nativeInit();

private native void nativeAppendMetadataItem(long nativePhysicalWebCollection,

- String requestUrl, double distanceEstimate, int scanTimestamp, String siteUrl,

+ String requestUrl, double distanceEstimate, long scanTimestamp, String siteUrl,

String iconUrl, String title, String description, String groupId);

private native void nativeOnFound(long nativePhysicalWebDataSourceAndroid, String url);

private native void nativeOnLost(long nativePhysicalWebDataSourceAndroid, String url);